Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: LayoutTests/editing/selection/contains-node-cleared-document.html

Issue 212873002: Remove Selection.containsNode assertion that is not valid. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/editing/selection/contains-node-cleared-document.html
diff --git a/LayoutTests/editing/selection/contains-node-crash.html b/LayoutTests/editing/selection/contains-node-cleared-document.html
similarity index 64%
copy from LayoutTests/editing/selection/contains-node-crash.html
copy to LayoutTests/editing/selection/contains-node-cleared-document.html
index ef0c04e93af34a058a72216d71b5fe1b4055acda..d73856642f24f6388ec1490ef6e5f91cde25653f 100644
--- a/LayoutTests/editing/selection/contains-node-crash.html
+++ b/LayoutTests/editing/selection/contains-node-cleared-document.html
@@ -9,10 +9,13 @@ window.onload = function() {
selection.selectAllChildren(document);
selection.collapseToEnd();
var element = document.activeElement;
+ var parent = element.parentNode;
document.open();
haraken 2014/03/26 13:06:30 I'm not sure if it's needed to open the document t
Mads Ager (chromium) 2014/03/26 13:18:00 This is pretty minimal. It is needed to open the d
- document.write("Pass. Test didn't crash.");
+ if (selection.containsNode(element,true))
haraken 2014/03/26 13:06:30 You can just write: shouldBeFalse("selection.co
Mads Ager (chromium) 2014/03/26 13:18:00 Unfortunately, that does not work. Probably becaus
+ document.write("FAIL: selection.containsNode should return false");
+ else
+ document.write("PASS");
document.close();
- selection.containsNode(element,true);
}
</script>
</html>

Powered by Google App Engine
This is Rietveld 408576698