Remove Selection.containsNode assertion that is not valid.

Source/core/page/DOMSelection.cpp

 /*
  * Copyright (C) 2007, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 463 matching lines @@
     unsigned nodeIndex = n->nodeIndex();
     RefPtr<Range> selectedRange = selection.selection().toNormalizedRange();
 
     ContainerNode* parentNode = n->parentNode();
     if (!parentNode)
         return false;
 
     TrackExceptionState exceptionState;
     bool nodeFullySelected = Range::compareBoundaryPoints(parentNode, nodeIndex, selectedRange->startContainer(), selectedRange->startOffset(), exceptionState) >= 0 && !exceptionState.hadException()
         && Range::compareBoundaryPoints(parentNode, nodeIndex + 1, selectedRange->endContainer(), selectedRange->endOffset(), exceptionState) <= 0 && !exceptionState.hadException();
-    ASSERT(!exceptionState.hadException());
+    if (exceptionState.hadException())
+        return false;
     if (nodeFullySelected)
         return true;
 
     bool nodeFullyUnselected = (Range::compareBoundaryPoints(parentNode, nodeIndex, selectedRange->endContainer(), selectedRange->endOffset(), exceptionState) > 0 && !exceptionState.hadException())
         || (Range::compareBoundaryPoints(parentNode, nodeIndex + 1, selectedRange->startContainer(), selectedRange->startOffset(), exceptionState) < 0 && !exceptionState.hadException());
     ASSERT(!exceptionState.hadException());

[haraken, 2014/03/26 13:06:30]

How about this ASSERT? Should we also fix this one? (You can do that in a
follow-up if you like.)

[Mads Ager (chromium), 2014/03/26 13:18:00]

I honestly don't know. I'm hoping that someone familiar with the selection code
can take the test case that I have here and see if they can get this to trigger.
I'm fixing this because I hit this with an unrelated oilpan change and noticed
that the assert above is wrong as it is.

     if (nodeFullyUnselected)
         return false;
 
     return allowPartial || n->isTextNode();
 }
 
 void DOMSelection::selectAllChildren(Node* n, ExceptionState& exceptionState)
 {
     if (!n)
         return;
@@ skipping 53 matching lines @@
     return node->document() == m_frame->document();
 }
 
 void DOMSelection::addConsoleError(const String& message)
 {
     if (m_treeScope)
         m_treeScope->document().addConsoleMessage(JSMessageSource, ErrorMessageLevel, message);
 }
 
 } // namespace WebCore