LayoutTests/editing/selection/contains-node-cleared-document.html - Issue 212873002: Remove Selection.containsNode assertion that is not valid.

Side by Side Diff: LayoutTests/editing/selection/contains-node-cleared-document.html

Issue 212873002: Remove Selection.containsNode assertion that is not valid. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>
	haraken 2014/03/26 13:06:30 You could make this test nicer by including js-tes You could make this test nicer by including js-test.js. Mads Ager (chromium) 2014/03/26 13:18:00 It seems that the way this test is messing with th Show quoted text On 2014/03/26 13:06:30, haraken wrote: > > You could make this test nicer by including js-test.js. It seems that the way this test is messing with the document makes that not work. This test was copied from contains-node-crash.html which does something similar. haraken 2014/03/26 13:20:19 oh I see, thanks. Show quoted text On 2014/03/26 13:18:00, Mads Ager (chromium) wrote: > On 2014/03/26 13:06:30, haraken wrote: > > > > You could make this test nicer by including js-test.js. > > It seems that the way this test is messing with the document makes that not > work. This test was copied from contains-node-crash.html which does something > similar. oh I see, thanks.
2 <html style="display: inline-table">	2 <html style="display: inline-table">

3 <script>	3 <script>

4 if (window.testRunner)	4 if (window.testRunner)

5 testRunner.dumpAsText();	5 testRunner.dumpAsText();
	haraken 2014/03/26 13:06:30 You can remove this. You can remove this. Mads Ager (chromium) 2014/03/26 13:18:00 Yes, but why not dump as text so that it is just a Show quoted text On 2014/03/26 13:06:30, haraken wrote: > > You can remove this. Yes, but why not dump as text so that it is just a nice "PASS" text? haraken 2014/03/26 13:20:19 I just meant, if you include js-test.js, it calls Show quoted text On 2014/03/26 13:18:00, Mads Ager (chromium) wrote: > On 2014/03/26 13:06:30, haraken wrote: > > > > You can remove this. > > Yes, but why not dump as text so that it is just a nice "PASS" text? I just meant, if you include js-test.js, it calls dumpAsText for you :)
6	6

7 window.onload = function() {	7 window.onload = function() {

8 var selection = window.getSelection();	8 var selection = window.getSelection();

9 selection.selectAllChildren(document);	9 selection.selectAllChildren(document);

10 selection.collapseToEnd();	10 selection.collapseToEnd();

11 var element = document.activeElement;	11 var element = document.activeElement;

	12 var parent = element.parentNode;

12 document.open();	13 document.open();
	haraken 2014/03/26 13:06:30 I'm not sure if it's needed to open the document t I'm not sure if it's needed to open the document to test what you want to test. You might want to minimize the test case. Mads Ager (chromium) 2014/03/26 13:18:00 This is pretty minimal. It is needed to open the d Show quoted text On 2014/03/26 13:06:30, haraken wrote: > > I'm not sure if it's needed to open the document to test what you want to test. > You might want to minimize the test case. This is pretty minimal. It is needed to open the document. That is the point. That the old document gets removed here and therefore we are asking a selection of a detached document.
13 document.write("Pass. Test didn't crash.");	14 if (selection.containsNode(element,true))
	haraken 2014/03/26 13:06:30 You can just write: shouldBeFalse("selection.co You can just write: shouldBeFalse("selection.containsNode(element, true)"); Nit: One space needed before 'true'. Mads Ager (chromium) 2014/03/26 13:18:00 Unfortunately, that does not work. Probably becaus Show quoted text On 2014/03/26 13:06:30, haraken wrote: > > You can just write: > > shouldBeFalse("selection.containsNode(element, true)"); > > Nit: One space needed before 'true'. Unfortunately, that does not work. Probably because I'm messing with the document here. I get null exceptions from the js-test.js code if I do that.
	15 document.write("FAIL: selection.containsNode should return false");

	16 else

	17 document.write("PASS");

14 document.close();	18 document.close();

15 selection.containsNode(element,true);

16 }	19 }

17 </script>	20 </script>

18 </html>	21 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/editing/selection/contains-node-cleared-document-expected.txt » ('j') | Source/core/page/DOMSelection.cpp » ('J')