Move settings_dropdown_menu styling to settings_shared_css.

Move settings_dropdown_menu styling to settings_shared_css.

BUG=625106
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/28370f6cb3fe36a2aa1d8aef51ca1aa5394f9285
Cr-Commit-Position: refs/heads/master@{#404294}

[stevenjb, 2016-07-07 01:34:31]

Description was changed from

==========
Move settings_dropdown_menu styling to settings_shared_css.

BUG=625106
==========

to

==========
Move settings_dropdown_menu styling to settings_shared_css.

BUG=625106
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2016-07-07 01:38:06]

stevenjb@chromium.org changed reviewers:
+ dpapad@chromium.org, dschuyler@chromium.org

[stevenjb, 2016-07-07 01:52:13]

dpapad@ - I didn't realize you were working on this, at least for the search
dropdown. I merged with your changes, LMKWYT.

[dpapad, 2016-07-07 17:15:05]

Are the following CSS rules still needed? Perhaps we can remove those too.

https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/site_s...
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/site_s...

https://codereview.chromium.org/2128173002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/people_page/sync_page.html (right):

https://codereview.chromium.org/2128173002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/sync_page.html:1: <title>Page
Title</title>
Is this needed or accidental? If needed, should it be localized?

[dschuyler, 2016-07-07 17:32:45]

stevenjb@ may I see a screen shot of a prefs based menu and non-prefs based menu
with the changes in this CL?

[stevenjb, 2016-07-07 18:45:57]

On 2016/07/07 17:15:05, dpapad wrote:
> Are the following CSS rules still needed? Perhaps we can remove those too.
> 
>
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/site_s...
>
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/site_s...
> 
Removed both.

[stevenjb, 2016-07-07 18:46:06]

https://codereview.chromium.org/2128173002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/people_page/sync_page.html (right):

https://codereview.chromium.org/2128173002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/sync_page.html:1: <title>Page
Title</title>
On 2016/07/07 17:15:05, dpapad wrote:
> Is this needed or accidental? If needed, should it be localized?

Sorry, accident, removed.

[stevenjb, 2016-07-07 18:49:38]

Patchset #4 (id:60001) has been deleted

[dpapad, 2016-07-07 21:03:56]

LGTM from my side, with nits.

https://codereview.chromium.org/2128173002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/media_picker.html (right):

https://codereview.chromium.org/2128173002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/media_picker.html:3: <link
rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.html">
No longer needed.

https://codereview.chromium.org/2128173002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/media_picker.html:20: <div
class="dropdown-item" media-picker-value$="[[item.id]]">
Let's add role="option" for accessibility.

https://codereview.chromium.org/2128173002/diff/80001/chrome/browser/resource...
File
chrome/browser/resources/settings/site_settings/site_details_permission.html
(right):

https://codereview.chromium.org/2128173002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_details_permission.html:5:
<link rel="import"
href="chrome://resources/polymer/v1_0/paper-item/paper-item.html">
No longer needed.

https://codereview.chromium.org/2128173002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_details_permission.html:64:
<div id="allow" class="dropdown-item"
Same here and below, role="option"

[stevenjb, 2016-07-07 21:39:06]

https://codereview.chromium.org/2128173002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/media_picker.html (right):

https://codereview.chromium.org/2128173002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/media_picker.html:3: <link
rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.html">
On 2016/07/07 21:03:55, dpapad wrote:
> No longer needed.

Done.

https://codereview.chromium.org/2128173002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/media_picker.html:20: <div
class="dropdown-item" media-picker-value$="[[item.id]]">
On 2016/07/07 21:03:55, dpapad wrote:
> Let's add role="option" for accessibility.

Done.

https://codereview.chromium.org/2128173002/diff/80001/chrome/browser/resource...
File
chrome/browser/resources/settings/site_settings/site_details_permission.html
(right):

https://codereview.chromium.org/2128173002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_details_permission.html:5:
<link rel="import"
href="chrome://resources/polymer/v1_0/paper-item/paper-item.html">
On 2016/07/07 21:03:55, dpapad wrote:
> No longer needed.

Done.

https://codereview.chromium.org/2128173002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_details_permission.html:64:
<div id="allow" class="dropdown-item"
On 2016/07/07 21:03:55, dpapad wrote:
> Same here and below, role="option"

Done.

[stevenjb, 2016-07-07 23:38:12]

On 2016/07/07 17:32:45, dschuyler wrote:
> stevenjb@ may I see a screen shot of a prefs based menu and non-prefs based
menu
> with the changes in this CL?

Screenshots (new UI):

https://screenshot.googleplex.com/B7sfFjmgK6h

https://screenshot.googleplex.com/AQojP7EZFOF

https://screenshot.googleplex.com/BKmUDCg2VRB

https://screenshot.googleplex.com/kvbudZ6fns0

[dschuyler, 2016-07-07 23:46:03]

lgtm

[stevenjb, 2016-07-08 00:20:36]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2016-07-08 00:20:37]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2128173002/#ps60002
(title: "More feedback")

[commit-bot: I haz the power, 2016-07-08 00:21:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 01:12:29]

Committed patchset #5 (id:60002)

[commit-bot: I haz the power, 2016-07-08 01:12:37]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-08 01:14:29]

Description was changed from

==========
Move settings_dropdown_menu styling to settings_shared_css.

BUG=625106
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Move settings_dropdown_menu styling to settings_shared_css.

BUG=625106
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/28370f6cb3fe36a2aa1d8aef51ca1aa5394f9285
Cr-Commit-Position: refs/heads/master@{#404294}
==========

[commit-bot: I haz the power, 2016-07-08 01:14:30]

Patchset 5 (id:??) landed as
https://crrev.com/28370f6cb3fe36a2aa1d8aef51ca1aa5394f9285
Cr-Commit-Position: refs/heads/master@{#404294}