Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5788)

Unified Diff: chrome/browser/resources/settings/controls/settings_dropdown_menu.html

Issue 2128173002: Move settings_dropdown_menu styling to settings_shared_css. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More feedback Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/people_page/sync_page.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/controls/settings_dropdown_menu.html
diff --git a/chrome/browser/resources/settings/controls/settings_dropdown_menu.html b/chrome/browser/resources/settings/controls/settings_dropdown_menu.html
index 716072b58f5b8550a363991a3422d6f61e76eb45..89654d12163039c555dfccf322e13019838bcfb1 100644
--- a/chrome/browser/resources/settings/controls/settings_dropdown_menu.html
+++ b/chrome/browser/resources/settings/controls/settings_dropdown_menu.html
@@ -9,31 +9,7 @@
<dom-module id="settings-dropdown-menu">
<template>
<style include="settings-shared">
- .item {
- align-items: center;
- color: var(--paper-grey-800);
- display: flex;
- font-size: inherit;
- min-height: 48px;
- padding: 0 16px;
- }
-
- .item:focus {
- background-color: var(--paper-grey-300);
- outline: none;
- }
-
- paper-dropdown-menu {
- --iron-icon-fill-color: var(--paper-grey-600);
- --paper-font-subhead: {
- font-size: inherit;
- };
- --paper-input-container-underline: {
- background: var(--paper-grey-300);
- };
- width: 160px;
- }
- </style>
+ </style>
<paper-dropdown-menu id="dropdownMenu" label="[[menuLabel_]]"
on-iron-select="onSelect_" no-label-float$="[[noLabelFloat]]"
disabled="[[shouldDisableMenu_(disabled, menuOptions.*)]]">
@@ -42,11 +18,12 @@
<template is="dom-repeat" items="[[menuOptions]]" initial-count="5">
<!--TODO(dpapad): Use <button class="paper-item">..</button> once it
lands in paper-item-shared-styles.html-->
- <div class="item" role="option" data-value$="[[item.value]]">
+ <div class="dropdown-item" role="option" data-value$="[[item.value]]">
[[item.name]]
</div>
</template>
- <div class="item" role="option" data-value$="[[notFoundValue_]]"
+ <div class="dropdown-item" role="option"
+ data-value$="[[notFoundValue_]]"
hidden$="[[!isSelectedNotFound_(selected_)]]">
$i18n{custom}
</div>
« no previous file with comments | « no previous file | chrome/browser/resources/settings/people_page/sync_page.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698