Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: chrome/browser/resources/settings/search_page/search_page.html

Issue 2128173002: Move settings_dropdown_menu styling to settings_shared_css. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More feedback Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/search_page/search_page.html
diff --git a/chrome/browser/resources/settings/search_page/search_page.html b/chrome/browser/resources/settings/search_page/search_page.html
index eb12862a651933f6ed9e2680aa3654cbdef03b25..675c940974e1989b86f5d3d54f6606f219efbfb8 100644
--- a/chrome/browser/resources/settings/search_page/search_page.html
+++ b/chrome/browser/resources/settings/search_page/search_page.html
@@ -12,28 +12,6 @@
<dom-module id="settings-search-page">
<template>
<style include="settings-shared">
- paper-dropdown-menu {
- /* TODO(dschuyler): share styling with settings-dropdown-menu */
- --iron-icon-fill-color: var(--paper-grey-600);
- }
-
- paper-listbox div {
- align-items: center;
- color: var(--paper-grey-800);
- display: flex;
- font-size: inherit;
- min-height: 48px;
- padding: 0 16px;
- }
-
- paper-listbox div.iron-selected {
- font-weight: bold;
- }
-
- paper-listbox div:focus {
- background-color: var(--paper-grey-300);
- outline: none;
- }
</style>
<settings-animated-pages id="pages" current-route="{{currentRoute}}"
section="search">
@@ -47,7 +25,7 @@
<template is="dom-repeat" items="[[searchEngines_]]">
<!--TODO(dpapad): Use <button class="paper-item">..</button>
once it lands in paper-item-shared-styles.html-->
- <div role="option">[[item.name]]</div>
+ <div class="dropdown-item" role="option">[[item.name]]</div>
</template>
</paper-listbox>
</paper-dropdown-menu>

Powered by Google App Engine
This is Rietveld 408576698