Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 2779253002: Switch from jinja to mustache templates (Closed)

Created:
3 years, 8 months ago by Yaron
Modified:
3 years, 8 months ago
Reviewers:
agrieve, hartmanng
CC:
chromium-reviews, zpeng+watch_chromium.org, pkotwicz, Xi Han
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch from jinja to mustache templates We are switching both client and server to the same template language as we'll soon need more advanced features like conditional sections. BUG=706510 Review-Url: https://codereview.chromium.org/2779253002 Cr-Commit-Position: refs/heads/master@{#461760} Committed: https://chromium.googlesource.com/chromium/src/+/5561a573e85ba1efa9eded4d64dfc547c6f77526

Patch Set 1 #

Patch Set 2 : Switch from jinja to mustache templates #

Patch Set 3 : switch template to no escaping #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -19 lines) Patch
M chrome/android/webapk/shell_apk/AndroidManifest.xml View 1 2 4 chunks +17 lines, -17 lines 0 comments Download
M chrome/android/webapk/shell_apk/BUILD.gn View 1 3 chunks +3 lines, -2 lines 0 comments Download
A chrome/android/webapk/shell_apk/manifest_processor.gni View 1 chunk +40 lines, -0 lines 0 comments Download
A chrome/android/webapk/shell_apk/manifest_processor.py View 1 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (15 generated)
Yaron
3 years, 8 months ago (2017-03-29 19:06:44 UTC) #8
hartmanng
lgtm
3 years, 8 months ago (2017-03-29 19:33:02 UTC) #9
Xi Han
I am not an expert in GN, add Andrew as a reviewer:)
3 years, 8 months ago (2017-03-30 13:49:29 UTC) #11
agrieve
On 2017/03/30 13:49:29, Xi Han wrote: > I am not an expert in GN, add ...
3 years, 8 months ago (2017-03-30 14:15:15 UTC) #12
Yaron
updated template variables to {{{ and }}} to match server changes. not revving the shell ...
3 years, 8 months ago (2017-04-04 15:23:06 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779253002/40001
3 years, 8 months ago (2017-04-04 15:23:43 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/186485)
3 years, 8 months ago (2017-04-04 15:51:04 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779253002/40001
3 years, 8 months ago (2017-04-04 15:54:45 UTC) #21
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 17:17:24 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5561a573e85ba1efa9eded4d64df...

Powered by Google App Engine
This is Rietveld 408576698