Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2126803004: WIP: NSS trust store integration for path builder. (Closed)

Created:
4 years, 5 months ago by mattm
Modified:
4 years, 4 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, sheretov+watch_chromium.org, dougsteed+watch_chromium.org, vadimgo+watch_chromium.org, ryanchung+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@cert-command-line-path-builder-add_certpathbuilder
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WIP: NSS trust store integration for path builder. * Changes TrustStore interface to allow async results. * Makes TrustStore be a CertIssuerSource instead of having its own custom way to retrieve the certs. * Introduces CertIssuerSourceCollection class to combine multiple CertIssuerSources instead of doing that inline in path builder. (May want to split this into separate CL.) * Similar for TrustStoreCollection. BUG=410574

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2667 lines, -593 lines) Patch
M components/cast_certificate/cast_cert_validator.cc View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M net/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M net/cert/internal/cert_issuer_source.h View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/internal/cert_issuer_source_aia.h View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/internal/cert_issuer_source_aia.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M net/cert/internal/cert_issuer_source_aia_unittest.cc View 1 2 18 chunks +17 lines, -21 lines 0 comments Download
A net/cert/internal/cert_issuer_source_collection.h View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
A net/cert/internal/cert_issuer_source_collection.cc View 1 1 chunk +145 lines, -0 lines 0 comments Download
A net/cert/internal/cert_issuer_source_collection_unittest.cc View 1 2 1 chunk +426 lines, -0 lines 0 comments Download
M net/cert/internal/cert_issuer_source_static.h View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/internal/cert_issuer_source_static.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/internal/cert_issuer_source_static_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A net/cert/internal/cert_issuer_source_test_helpers.h View 1 2 1 chunk +91 lines, -0 lines 0 comments Download
A net/cert/internal/cert_issuer_source_test_helpers.cc View 1 2 1 chunk +81 lines, -0 lines 0 comments Download
M net/cert/internal/path_builder.h View 2 chunks +9 lines, -3 lines 0 comments Download
M net/cert/internal/path_builder.cc View 1 2 24 chunks +115 lines, -92 lines 0 comments Download
M net/cert/internal/path_builder_pkits_unittest.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M net/cert/internal/path_builder_unittest.cc View 1 2 43 chunks +147 lines, -245 lines 0 comments Download
M net/cert/internal/path_builder_verify_certificate_chain_unittest.cc View 2 chunks +13 lines, -9 lines 0 comments Download
M net/cert/internal/test_helpers.h View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M net/cert/internal/test_helpers.cc View 1 2 3 chunks +87 lines, -10 lines 0 comments Download
M net/cert/internal/trust_store.h View 2 chunks +39 lines, -34 lines 0 comments Download
D net/cert/internal/trust_store.cc View 1 1 chunk +0 lines, -46 lines 0 comments Download
A net/cert/internal/trust_store_collection.h View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
A net/cert/internal/trust_store_collection.cc View 1 2 1 chunk +112 lines, -0 lines 0 comments Download
A net/cert/internal/trust_store_collection_unittest.cc View 1 2 1 chunk +261 lines, -0 lines 0 comments Download
A net/cert/internal/trust_store_nss.h View 1 chunk +51 lines, -0 lines 0 comments Download
A net/cert/internal/trust_store_nss.cc View 1 2 1 chunk +203 lines, -0 lines 0 comments Download
A net/cert/internal/trust_store_nss_unittest.cc View 1 2 1 chunk +431 lines, -0 lines 0 comments Download
A net/cert/internal/trust_store_static.h View 1 chunk +64 lines, -0 lines 0 comments Download
A net/cert/internal/trust_store_static.cc View 1 chunk +47 lines, -0 lines 0 comments Download
A net/cert/internal/trust_store_test_helpers.h View 1 2 1 chunk +71 lines, -0 lines 0 comments Download
A net/cert/internal/trust_store_test_helpers.cc View 1 2 1 chunk +88 lines, -0 lines 0 comments Download
M net/cert/internal/verify_certificate_chain.h View 2 chunks +0 lines, -6 lines 0 comments Download
M net/cert/internal/verify_certificate_chain.cc View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M net/cert/internal/verify_certificate_chain_pkits_unittest.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M net/cert/internal/verify_certificate_chain_typed_unittest.h View 1 2 2 chunks +3 lines, -84 lines 0 comments Download
M net/cert/internal/verify_certificate_chain_unittest.cc View 3 chunks +1 line, -4 lines 0 comments Download
M net/net.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M net/net.gypi View 1 2 4 chunks +15 lines, -1 line 0 comments Download
M net/tools/cert_verify_tool/verify_using_path_builder.cc View 4 chunks +21 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
mattm
4 years, 5 months ago (2016-07-07 02:00:13 UTC) #3
Just sending this as an FYI so you can see what I have in flight. You could do a
high-level review of the design & interfaces if you want.

Powered by Google App Engine
This is Rietveld 408576698