Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Unified Diff: net/cert/internal/path_builder_verify_certificate_chain_unittest.cc

Issue 2126803004: WIP: NSS trust store integration for path builder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cert-command-line-path-builder-add_certpathbuilder
Patch Set: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/internal/path_builder_unittest.cc ('k') | net/cert/internal/test_helpers.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/internal/path_builder_verify_certificate_chain_unittest.cc
diff --git a/net/cert/internal/path_builder_verify_certificate_chain_unittest.cc b/net/cert/internal/path_builder_verify_certificate_chain_unittest.cc
index e08ea30895beff8e049380a3b49727176ff180d5..32517594c8d74b812cd2f70640dc765cc26804e1 100644
--- a/net/cert/internal/path_builder_verify_certificate_chain_unittest.cc
+++ b/net/cert/internal/path_builder_verify_certificate_chain_unittest.cc
@@ -6,7 +6,7 @@
#include "net/cert/internal/cert_issuer_source_static.h"
#include "net/cert/internal/signature_policy.h"
-#include "net/cert/internal/trust_store.h"
+#include "net/cert/internal/trust_store_static.h"
#include "net/cert/internal/verify_certificate_chain_typed_unittest.h"
namespace net {
@@ -22,19 +22,23 @@ class PathBuilderDelegate {
SimpleSignaturePolicy signature_policy(1024);
ASSERT_FALSE(chain.empty());
- TrustStore trust_store;
- for (const auto& root : roots)
+ TrustStoreStatic trust_store;
+ CertIssuerSourceStatic cert_issuer_source;
+
+ for (const auto& root : roots) {
trust_store.AddTrustedCertificate(root);
+ cert_issuer_source.AddCert(root);
+ }
- CertIssuerSourceStatic intermediate_cert_issuer_source;
- for (size_t i = 1; i < chain.size(); ++i)
- intermediate_cert_issuer_source.AddCert(chain[i]);
+ for (const auto& cert : chain)
+ cert_issuer_source.AddCert(cert);
CertPathBuilder::Result result;
// First cert in the |chain| is the target.
- CertPathBuilder path_builder(chain.front(), &trust_store, &signature_policy,
- time, &result);
- path_builder.AddCertIssuerSource(&intermediate_cert_issuer_source);
+ CertPathBuilder path_builder(chain.front(), &signature_policy, time,
+ &result);
+ path_builder.AddTrustStore(&trust_store);
+ path_builder.AddCertIssuerSource(&cert_issuer_source);
CompletionStatus rv = path_builder.Run(base::Closure());
EXPECT_EQ(CompletionStatus::SYNC, rv);
« no previous file with comments | « net/cert/internal/path_builder_unittest.cc ('k') | net/cert/internal/test_helpers.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698