Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: net/cert/internal/cert_issuer_source_aia.cc

Issue 2126803004: WIP: NSS trust store integration for path builder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cert-command-line-path-builder-add_certpathbuilder
Patch Set: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/internal/cert_issuer_source_aia.h ('k') | net/cert/internal/cert_issuer_source_aia_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/internal/cert_issuer_source_aia.cc
diff --git a/net/cert/internal/cert_issuer_source_aia.cc b/net/cert/internal/cert_issuer_source_aia.cc
index 5ee96a07831110187e2023ff02fe5219e69ce6e1..942b6fc1a7ff45e6c6d4aff818b67de1b5e16edb 100644
--- a/net/cert/internal/cert_issuer_source_aia.cc
+++ b/net/cert/internal/cert_issuer_source_aia.cc
@@ -99,6 +99,7 @@ void AiaRequest::OnFetchCompleted(Error error,
// stop waiting.)
if (client_waiting_for_callback && (HasNext() || pending_requests_ == 0))
issuers_callback_.Run(this);
+ // |this| may be deleted here.
}
} // namespace
@@ -114,7 +115,7 @@ void CertIssuerSourceAia::SyncGetIssuersOf(const ParsedCertificate* cert,
}
void CertIssuerSourceAia::AsyncGetIssuersOf(
- const ParsedCertificate* cert,
+ scoped_refptr<ParsedCertificate> cert,
const IssuerCallback& issuers_callback,
std::unique_ptr<Request>* out_req) {
out_req->reset();
« no previous file with comments | « net/cert/internal/cert_issuer_source_aia.h ('k') | net/cert/internal/cert_issuer_source_aia_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698