Remove the prototype from all V8 functions that aren't constructors

Remove the prototype from all V8 functions that aren't constructors

BUG=625823
R=haraken@chromium.org
TBR=eroman@chromium.org,yzshen@chromium.org

Committed: https://crrev.com/596fd5ed32fdcce384a3a5f6453582919bef6528
Cr-Commit-Position: refs/heads/master@{#403888}

[jochen (gone - plz use gerrit), 2016-07-06 08:50:39]

ptal

[haraken, 2016-07-06 08:55:37]

LGTM

Can we add some assert to check that non-constructor functions don't have
prototypes?

[jochen (gone - plz use gerrit), 2016-07-06 08:56:32]

where would you add that?

[haraken, 2016-07-06 08:57:15]

On 2016/07/06 08:56:32, jochen wrote:
> where would you add that?

I have no concrete idea :) How did you find those places?

[jochen (gone - plz use gerrit), 2016-07-06 08:57:38]

On 2016/07/06 at 08:57:15, haraken wrote:
> On 2016/07/06 08:56:32, jochen wrote:
> > where would you add that?
> 
> I have no concrete idea :) How did you find those places?

git grep -l FunctionTemplate::New

[haraken, 2016-07-06 08:58:37]

On 2016/07/06 08:57:38, jochen wrote:
> On 2016/07/06 at 08:57:15, haraken wrote:
> > On 2016/07/06 08:56:32, jochen wrote:
> > > where would you add that?
> > 
> > I have no concrete idea :) How did you find those places?
> 
> git grep -l FunctionTemplate::New

OK. I don't have an idea to add the assert in bindings.

[jochen (gone - plz use gerrit), 2016-07-06 09:00:54]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2016-07-06 09:01:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-07-06 11:08:43]

jochen@chromium.org changed reviewers:
+ yzshen@google.com

[jochen (gone - plz use gerrit), 2016-07-06 11:08:59]

Description was changed from

==========
Remove the prototype from all V8 functions that aren't constructors

BUG=625823
R=haraken@chromium.org
TBR=eroman@chromium.org
==========

to

==========
Remove the prototype from all V8 functions that aren't constructors

BUG=625823
R=haraken@chromium.org
TBR=eroman@chromium.org,yzshen@chromium.org
==========

[jochen (gone - plz use gerrit), 2016-07-06 11:09:25]

jochen@chromium.org changed reviewers:
+ yzshen@chromium.org
- yzshen@google.com

[jochen (gone - plz use gerrit), 2016-07-06 11:09:26]

tbr'ing eroman@ for net/ and yzshen@ for mojo/

[jochen (gone - plz use gerrit), 2016-07-06 11:09:32]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-07-06 11:09:33]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2126763002/#ps40001
(title: "updates")

[commit-bot: I haz the power, 2016-07-06 11:09:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 12:30:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-06 12:31:23]

Description was changed from

==========
Remove the prototype from all V8 functions that aren't constructors

BUG=625823
R=haraken@chromium.org
TBR=eroman@chromium.org,yzshen@chromium.org
==========

to

==========
Remove the prototype from all V8 functions that aren't constructors

BUG=625823
R=haraken@chromium.org
TBR=eroman@chromium.org,yzshen@chromium.org

Committed: https://crrev.com/596fd5ed32fdcce384a3a5f6453582919bef6528
Cr-Commit-Position: refs/heads/master@{#403888}
==========

[commit-bot: I haz the power, 2016-07-06 12:31:24]

Patchset 3 (id:??) landed as
https://crrev.com/596fd5ed32fdcce384a3a5f6453582919bef6528
Cr-Commit-Position: refs/heads/master@{#403888}

[yzshen1, 2016-07-06 16:59:50]

On 2016/07/06 12:31:24, commit-bot: I haz the power wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/596fd5ed32fdcce384a3a5f6453582919bef6528
> Cr-Commit-Position: refs/heads/master@{#403888}

LGTM for mojo. Thanks!

[eroman, 2016-07-06 18:01:58]

lgtm