third_party/WebKit/Source/bindings/core/v8/DocumentWriteEvaluator.cpp - Issue 2126763002: Remove the prototype from all V8 functions that aren't constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/DocumentWriteEvaluator.cpp

Issue 2126763002: Remove the prototype from all V8 functions that aren't constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/Window/window-methods-construct.html ('k') | third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/DocumentWriteEvaluator.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/DocumentWriteEvaluator.cpp b/third_party/WebKit/Source/bindings/core/v8/DocumentWriteEvaluator.cpp

index 34e9b52ae25b89992f0e079b524a834de576d999..66af96ee87dab8644f9bfa595357aa709e0cb7de 100644

--- a/third_party/WebKit/Source/bindings/core/v8/DocumentWriteEvaluator.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/DocumentWriteEvaluator.cpp

@@ -102,6 +102,7 @@ bool DocumentWriteEvaluator::ensureEvaluationContext()

m_window.newLocal(isolate)->Set(navigatorString, m_navigator.newLocal(isolate));

v8::Local<v8::FunctionTemplate> writeTemplate = v8::FunctionTemplate::New(isolate, documentWriteCallback, v8::External::New(isolate, this));

+ writeTemplate->RemovePrototype();

m_document.newLocal(isolate)->Set(locationString, m_location.newLocal(isolate));

m_document.newLocal(isolate)->Set(v8String(isolate, "write"), writeTemplate->GetFunction());

m_document.newLocal(isolate)->Set(v8String(isolate, "writeln"), writeTemplate->GetFunction());