third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp - Issue 2126763002: Remove the prototype from all V8 functions that aren't constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp

Issue 2126763002: Remove the prototype from all V8 functions that aren't constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp

index baeb5c30ad90c60200dc696907d9b99f4eb32e41..00a1df1e3e3746ef394f49fc0d40872d35390750 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp

@@ -277,6 +277,7 @@ v8::Local<v8::FunctionTemplate> V8PerIsolateData::findOrCreateOperationTemplate(

return result->value.Get(isolate());

v8::Local<v8::FunctionTemplate> templ = v8::FunctionTemplate::New(isolate(), callback, data, signature, length);

+ templ->RemovePrototype();

map.add(key, v8::Eternal<v8::FunctionTemplate>(isolate(), templ));

return templ;

}

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp ('k') | no next file » | no next file with comments »