Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2126083002: Remove fColor from PathRenderer DrawPathArgs struct (Closed)

Created:
4 years, 5 months ago by robertphillips
Modified:
4 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove fColor from PathRenderer DrawPathArgs struct This was getting in the way of other refactorings. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2126083002 Committed: https://skia.googlesource.com/skia/+/3950f0d7239c05687ac96c211e49ceab9ab9ff4d

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unnecessary GrPaint::setColor calls #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -55 lines) Patch
M src/gpu/GrClipMaskManager.cpp View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/gpu/GrPathRenderer.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/gpu/GrSWMaskHelper.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrSoftwarePathRenderer.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/gpu/GrSoftwarePathRenderer.cpp View 4 chunks +15 lines, -16 lines 0 comments Download
M src/gpu/batches/GrAAConvexPathRenderer.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/batches/GrAADistanceFieldPathRenderer.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/batches/GrAAHairLinePathRenderer.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/batches/GrAALinearizingConvexPathRenderer.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/batches/GrDashLinePathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrDefaultPathRenderer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/batches/GrDefaultPathRenderer.cpp View 1 5 chunks +4 lines, -5 lines 0 comments Download
M src/gpu/batches/GrMSAAPathRenderer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/batches/GrMSAAPathRenderer.cpp View 1 5 chunks +3 lines, -5 lines 0 comments Download
M src/gpu/batches/GrPLSPathRenderer.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/batches/GrStencilAndCoverPathRenderer.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/batches/GrTessellatingPathRenderer.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M tests/TessellatingPathRendererTests.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 19 (10 generated)
robertphillips
4 years, 5 months ago (2016-07-07 13:05:44 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126083002/1
4 years, 5 months ago (2016-07-07 13:05:53 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-07 13:21:04 UTC) #8
bsalomon
lgtm https://codereview.chromium.org/2126083002/diff/1/src/gpu/GrClipMaskManager.cpp File src/gpu/GrClipMaskManager.cpp (right): https://codereview.chromium.org/2126083002/diff/1/src/gpu/GrClipMaskManager.cpp#newcode664 src/gpu/GrClipMaskManager.cpp:664: paint.setColor4f(GrColor4f(1.0f, 1.0f, 1.0f, 1.0f)); Should we have a ...
4 years, 5 months ago (2016-07-07 13:53:22 UTC) #9
robertphillips
https://codereview.chromium.org/2126083002/diff/1/src/gpu/GrClipMaskManager.cpp File src/gpu/GrClipMaskManager.cpp (right): https://codereview.chromium.org/2126083002/diff/1/src/gpu/GrClipMaskManager.cpp#newcode664 src/gpu/GrClipMaskManager.cpp:664: paint.setColor4f(GrColor4f(1.0f, 1.0f, 1.0f, 1.0f)); On 2016/07/07 13:53:22, bsalomon wrote: ...
4 years, 5 months ago (2016-07-07 14:10:55 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126083002/20001
4 years, 5 months ago (2016-07-07 14:11:08 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-07 14:30:00 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126083002/20001
4 years, 5 months ago (2016-07-07 14:31:47 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 14:33:17 UTC) #19
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/3950f0d7239c05687ac96c211e49ceab9ab9ff4d

Powered by Google App Engine
This is Rietveld 408576698