src/gpu/batches/GrPLSPathRenderer.cpp - Issue 2126083002: Remove fColor from PathRenderer DrawPathArgs struct

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/batches/GrPLSPathRenderer.cpp

Issue 2126083002: Remove fColor from PathRenderer DrawPathArgs struct (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Remove unnecessary GrPaint::setColor calls Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/batches/GrPLSPathRenderer.cpp

diff --git a/src/gpu/batches/GrPLSPathRenderer.cpp b/src/gpu/batches/GrPLSPathRenderer.cpp

index c373979bb58e163db0b6618480b6857ed9e7dc0f..6ec5a3af98bcb88dc33a59d7883bdf6d88e1df58 100644

--- a/src/gpu/batches/GrPLSPathRenderer.cpp

+++ b/src/gpu/batches/GrPLSPathRenderer.cpp

@@ -948,7 +948,8 @@ bool GrPLSPathRenderer::onDrawPath(const DrawPathArgs& args) {

SkPath path;

args.fShape->asPath(&path);

- SkAutoTUnref<GrDrawBatch> batch(new PLSPathBatch(args.fColor, path, *args.fViewMatrix));

+ SkAutoTUnref<GrDrawBatch> batch(new PLSPathBatch(args.fPaint->getColor(),

+ path, *args.fViewMatrix));

GrPipelineBuilder pipelineBuilder(*args.fPaint, args.fDrawContext->mustUseHWAA(*args.fPaint));

pipelineBuilder.setUserStencil(args.fUserStencilSettings);