Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2126013002: Fix canvas blink_perf tests to avoid GPU fallback (Closed)

Created:
4 years, 5 months ago by Justin Novosad
Modified:
4 years, 5 months ago
Reviewers:
xidachen
CC:
chromium-reviews, blink-reviews, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix canvas blink_perf tests to avoid GPU fallback There is an artificial regression in some of the canvas performance tests after landing commit 627ddfd0de197d67567a15191f654b8835408bce this change fixes the tests to prevent them from triggering the fallback to CPU-based rendering. BUG=606688 Committed: https://crrev.com/f0fad4a76fcb3105f871ad93311a13cd83cd6bd8 Cr-Commit-Position: refs/heads/master@{#403957}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix details #

Patch Set 3 : whoops #

Messages

Total messages: 14 (7 generated)
Justin Novosad
PTAL
4 years, 5 months ago (2016-07-06 19:53:54 UTC) #2
xidachen
lgtm https://codereview.chromium.org/2126013002/diff/1/third_party/WebKit/PerformanceTests/Canvas/draw-dynamic-canvas-2d-to-hw-accelerated-canvas-2d.html File third_party/WebKit/PerformanceTests/Canvas/draw-dynamic-canvas-2d-to-hw-accelerated-canvas-2d.html (right): https://codereview.chromium.org/2126013002/diff/1/third_party/WebKit/PerformanceTests/Canvas/draw-dynamic-canvas-2d-to-hw-accelerated-canvas-2d.html#newcode40 third_party/WebKit/PerformanceTests/Canvas/draw-dynamic-canvas-2d-to-hw-accelerated-canvas-2d.html:40: // Using destCanvas2D a source image is just ...
4 years, 5 months ago (2016-07-06 20:16:25 UTC) #3
Justin Novosad
fixed, thx.
4 years, 5 months ago (2016-07-06 20:19:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126013002/40001
4 years, 5 months ago (2016-07-06 20:22:36 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-06 21:39:34 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 21:39:41 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 21:41:24 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f0fad4a76fcb3105f871ad93311a13cd83cd6bd8
Cr-Commit-Position: refs/heads/master@{#403957}

Powered by Google App Engine
This is Rietveld 408576698