Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2125973002: Reland: ScreenCapture for Android phase1, part I (Closed)

Created:
4 years, 5 months ago by braveyao
Modified:
4 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: ScreenCapture for Android phase1, part I (patchset #12 id:340001 https://codereview.chromium.org/1917023003/) Which got reverted due to breakage of compiling on Android bots intermittently. (see https://codereview.chromium.org/2116883002) Recenctly, media/capture/video/video_capture_device.h starts to include media/mojo/interfaces/image_capture.mojom.h, which also requests the dependency to //media/mojo/interfaces:image_capture. So does same thing to media/capture/content/android/BUILD.gn. No other changed involved. Original description -------------------------------------- ScreenCapture for Android phase1, part I The document about ScreenCapture for Android is here, https://goo.gl/QNH29g. This cl is mainly based on the https://codereview.chromium.org/1140113002/. Only the codes under media/ are included here, which implements the JAVA capture with Android MediaProjection API and JNI connectors, with some issues fixed so it can always work. The control part in content/ and chrome/ will be in the next cl, as part II. BUG=487935 ----------------------------------------------------------------------- BUG = 487935 TBR=dalecurtis@chromium.org,mcasas@chromium.org,michaelbai@chromium.org,miu@chromium.org,qinmin@chromium.org,tedchoc@chromium.org Committed: https://crrev.com/7508a100080e04e8c430777aab7cb91cbcdd1ced Cr-Commit-Position: refs/heads/master@{#403996}

Patch Set 1 : patchset #12 id:340001 https://codereview.chromium.org/1917023003/ #

Patch Set 2 : add dependency to mojo/interfaces:image_capture #

Unified diffs Side-by-side diffs Delta from patch set Stats (+877 lines, -1 line) Patch
M chrome/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/app/android/library_loader_hooks.cc View 2 chunks +4 lines, -0 lines 0 comments Download
A content/browser/media/capture/screen_capture_device_android.h View 1 chunk +37 lines, -0 lines 0 comments Download
A content/browser/media/capture/screen_capture_device_android.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/android/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M media/capture/BUILD.gn View 1 chunk +6 lines, -1 line 0 comments Download
A media/capture/content/android/BUILD.gn View 1 1 chunk +43 lines, -0 lines 0 comments Download
A media/capture/content/android/java/src/org/chromium/media/ScreenCapture.java View 1 chunk +350 lines, -0 lines 0 comments Download
A media/capture/content/android/screen_capture_jni_registrar.h View 1 chunk +19 lines, -0 lines 0 comments Download
A media/capture/content/android/screen_capture_jni_registrar.cc View 1 chunk +24 lines, -0 lines 0 comments Download
A media/capture/content/android/screen_capture_machine_android.h View 1 chunk +77 lines, -0 lines 0 comments Download
A media/capture/content/android/screen_capture_machine_android.cc View 1 chunk +278 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
miu
Diff between PS2 and PS1 lgtm.
4 years, 5 months ago (2016-07-06 21:48:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125973002/20001
4 years, 5 months ago (2016-07-06 23:05:33 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-07 00:07:23 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 00:07:44 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 00:09:31 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7508a100080e04e8c430777aab7cb91cbcdd1ced
Cr-Commit-Position: refs/heads/master@{#403996}

Powered by Google App Engine
This is Rietveld 408576698