Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Issue 2116883002: Revert of ScreenCapture for Android phase1, part I (Closed)

Created:
4 years, 5 months ago by kelvinp
Modified:
4 years, 5 months ago
CC:
avayvod+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, mlamouri+watch-media_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ScreenCapture for Android phase1, part I (patchset #12 id:340001 of https://codereview.chromium.org/1917023003/ ) Reason for revert: Break compile step on Android Builder logs: https://build.chromium.org/p/chromium/builders/Android/builds/58512/steps/compile/logs/stdio Failure: In file included from ../../media/capture/content/thread_safe_capture_oracle.h:15:0, from ../../media/capture/content/screen_capture_device_core.h:15, from ../../media/capture/content/android/screen_capture_machine_android.h:12, from ../../media/capture/content/android/screen_capture_jni_registrar.cc:10: ../../media/capture/video/video_capture_device.h:33:55: fatal error: media/mojo/interfaces/image_capture.mojom.h: No such file or directory #include "media/mojo/interfaces/image_capture.mojom.h" Original issue's description: > ScreenCapture for Android phase1, part I > > The document about ScreenCapture for Android is here, https://goo.gl/QNH29g. > This cl is mainly based on the https://codereview.chromium.org/1140113002/. > Only the codes under media/ are included here, which implements the JAVA > capture with Android MediaProjection API and JNI connectors, with some issues > fixed so it can always work. > The control part in content/ and chrome/ will be in the next cl, as part II. > > BUG=487935 > > Committed: https://crrev.com/2f731e17983201082d9fc725cf7717868fc1e75d > Cr-Commit-Position: refs/heads/master@{#403555} TBR=dalecurtis@chromium.org,mcasas@chromium.org,michaelbai@chromium.org,miu@chromium.org,qinmin@chromium.org,sergeyu@chromium.org,tedchoc@chromium.org,braveyao@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=487935 Committed: https://crrev.com/f9fdeda904daa23f306c6adc9f629756db3beeed Cr-Commit-Position: refs/heads/master@{#403557}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -876 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/app/android/library_loader_hooks.cc View 2 chunks +0 lines, -4 lines 0 comments Download
D content/browser/media/capture/screen_capture_device_android.h View 1 chunk +0 lines, -37 lines 0 comments Download
D content/browser/media/capture/screen_capture_device_android.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/android/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M media/capture/BUILD.gn View 1 chunk +1 line, -6 lines 0 comments Download
D media/capture/content/android/BUILD.gn View 1 chunk +0 lines, -42 lines 0 comments Download
D media/capture/content/android/java/src/org/chromium/media/ScreenCapture.java View 1 chunk +0 lines, -350 lines 0 comments Download
D media/capture/content/android/screen_capture_jni_registrar.h View 1 chunk +0 lines, -19 lines 0 comments Download
D media/capture/content/android/screen_capture_jni_registrar.cc View 1 chunk +0 lines, -24 lines 0 comments Download
D media/capture/content/android/screen_capture_machine_android.h View 1 chunk +0 lines, -77 lines 0 comments Download
D media/capture/content/android/screen_capture_machine_android.cc View 1 chunk +0 lines, -278 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kelvinp
Created Revert of ScreenCapture for Android phase1, part I
4 years, 5 months ago (2016-07-01 22:58:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116883002/1
4 years, 5 months ago (2016-07-01 22:58:44 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 22:59:36 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 22:59:40 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 23:01:27 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9fdeda904daa23f306c6adc9f629756db3beeed
Cr-Commit-Position: refs/heads/master@{#403557}

Powered by Google App Engine
This is Rietveld 408576698