Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2125963002: Fix SystemWebView.apk's resource_rewriter()'s pass. (Closed)

Created:
4 years, 5 months ago by agrieve
Modified:
4 years, 5 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix SystemWebView.apk's resource_rewriter()'s pass. It was broken by upstream change: https://codereview.chromium.org/2109293003 BUG=625336 Committed: https://crrev.com/e2198a1d89da476f6a150f64834d702fc78a7c8a Cr-Commit-Position: refs/heads/master@{#403940}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M android_webview/glue/generate_resource_rewriter.gni View 2 chunks +2 lines, -4 lines 2 comments Download

Messages

Total messages: 15 (6 generated)
agrieve
4 years, 5 months ago (2016-07-06 18:30:45 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125963002/1
4 years, 5 months ago (2016-07-06 18:31:00 UTC) #4
michaelbai
thanks, LGTM
4 years, 5 months ago (2016-07-06 18:40:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125963002/1
4 years, 5 months ago (2016-07-06 18:56:41 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 19:35:32 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 19:35:40 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e2198a1d89da476f6a150f64834d702fc78a7c8a Cr-Commit-Position: refs/heads/master@{#403940}
4 years, 5 months ago (2016-07-06 19:37:40 UTC) #12
Tima Vaisburd
https://codereview.chromium.org/2125963002/diff/1/android_webview/glue/generate_resource_rewriter.gni File android_webview/glue/generate_resource_rewriter.gni (right): https://codereview.chromium.org/2125963002/diff/1/android_webview/glue/generate_resource_rewriter.gni#newcode29 android_webview/glue/generate_resource_rewriter.gni:29: possible_config_deps = invoker.deps drive-by: Where is |possible_config_deps| used?
4 years, 5 months ago (2016-07-12 20:11:01 UTC) #14
agrieve
4 years, 5 months ago (2016-07-12 20:18:02 UTC) #15
Message was sent while issue was closed.
https://codereview.chromium.org/2125963002/diff/1/android_webview/glue/genera...
File android_webview/glue/generate_resource_rewriter.gni (right):

https://codereview.chromium.org/2125963002/diff/1/android_webview/glue/genera...
android_webview/glue/generate_resource_rewriter.gni:29: possible_config_deps =
invoker.deps
On 2016/07/12 20:11:01, Tima Vaisburd wrote:
> drive-by: Where is |possible_config_deps| used?

https://cs.chromium.org/chromium/src/build/config/android/internal_rules.gni?...

It's used to tell write_build_config what other write_build_config targets
exist.

Powered by Google App Engine
This is Rietveld 408576698