Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2109293003: 🎊 Reland #2 of Have build_config targets depend only on other build_config targets (Closed)

Created:
4 years, 5 months ago by agrieve
Modified:
4 years, 5 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Peter Beverloo, jam, darin-cc_chromium.org, mikecase+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, jbudorick+watch_chromium.org, jochen+watch_chromium.org, pkotwicz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland #2 of Have build_config targets depend only on other build_config targets Reason for revert: Now tested with webview-related downstream gn args enabled. TBR=brettw BUG=620034 Committed: https://crrev.com/24b56ca83db3ac262fd223a328911f3878752ffd Cr-Commit-Position: refs/heads/master@{#403173}

Patch Set 1 #

Patch Set 2 : change // to * to fix downstream #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -57 lines) Patch
M build/android/gyp/write_build_config.py View 1 2 chunks +3 lines, -12 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 9 chunks +114 lines, -19 lines 0 comments Download
M build/config/android/rules.gni View 1 12 chunks +40 lines, -19 lines 0 comments Download
M chromecast/browser/android/BUILD.gn View 1 1 chunk +1 line, -3 lines 0 comments Download
M content/shell/android/BUILD.gn View 1 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
agrieve
Created Reland of 🎊 Reland of Have build_config targets depend only on other build_config targets
4 years, 5 months ago (2016-06-30 13:32:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109293003/110001
4 years, 5 months ago (2016-06-30 13:41:25 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:110001)
4 years, 5 months ago (2016-06-30 14:46:48 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 14:46:57 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 14:48:58 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/24b56ca83db3ac262fd223a328911f3878752ffd
Cr-Commit-Position: refs/heads/master@{#403173}

Powered by Google App Engine
This is Rietveld 408576698