Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: android_webview/glue/generate_resource_rewriter.gni

Issue 2125963002: Fix SystemWebView.apk's resource_rewriter()'s pass. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/glue/generate_resource_rewriter.gni
diff --git a/android_webview/glue/generate_resource_rewriter.gni b/android_webview/glue/generate_resource_rewriter.gni
index ff102f9c03f42bec3f1ac14c6cd5463562d2f13a..59581df2e52a78a8321ee7ff9bebb4a9b90461ca 100644
--- a/android_webview/glue/generate_resource_rewriter.gni
+++ b/android_webview/glue/generate_resource_rewriter.gni
@@ -26,7 +26,7 @@ template("generate_resource_rewriter") {
_build_config_target_name = "${target_name}__build_config"
_srcjar = "$target_gen_dir/${target_name}.srcjar"
write_build_config(_build_config_target_name) {
- deps = invoker.deps
+ possible_config_deps = invoker.deps
Tima Vaisburd 2016/07/12 20:11:01 drive-by: Where is |possible_config_deps| used?
agrieve 2016/07/12 20:18:01 https://cs.chromium.org/chromium/src/build/config/
type = "resource_rewriter"
build_config = _build_config
}
@@ -36,9 +36,7 @@ template("generate_resource_rewriter") {
inputs = [
_build_config,
]
- deps = [
- ":${_build_config_target_name}",
- ]
+ deps = invoker.deps + [ ":${_build_config_target_name}" ]
script = "//build/android/gyp/generate_resource_rewriter.py"
_rebased_build_config = rebase_path(_build_config)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698