go/src/infra/monitoring/proxy/pubsub.go - Issue 2125943003: Updated moniroting/proxy and cloudtail/client with tsmon's unit annotation supports.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: go/src/infra/monitoring/proxy/pubsub.go

Issue 2125943003: Updated moniroting/proxy and cloudtail/client with tsmon's unit annotation supports. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Update DEPS with the revision of luci-go with crrev.com/2123853002 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: go/src/infra/monitoring/proxy/pubsub.go

diff --git a/go/src/infra/monitoring/proxy/pubsub.go b/go/src/infra/monitoring/proxy/pubsub.go

index f54eb4ff032147b03b9830faea732161205e0dcc..cb99a3b171955374c14457daea2af6f0f2539ba2 100644

--- a/go/src/infra/monitoring/proxy/pubsub.go

+++ b/go/src/infra/monitoring/proxy/pubsub.go

@@ -17,6 +17,7 @@ import (

"github.com/luci/luci-go/common/tsmon/distribution"

"github.com/luci/luci-go/common/tsmon/field"

"github.com/luci/luci-go/common/tsmon/metric"

+ "github.com/luci/luci-go/common/tsmon/types"

"golang.org/x/net/context"

"google.golang.org/cloud"

"google.golang.org/cloud/pubsub"

@@ -39,15 +40,19 @@ var (

messageCount = metric.NewCounter("mon_proxy/pubsub/message",

"Count of messages pulled from pub/sub, by worker",

+ types.MetricMetadata{},

field.Int("worker"))

ackCount = metric.NewCounter("mon_proxy/pubsub/ack",

"Count of messages Ack'd, by success/failure",

+ types.MetricMetadata{},

field.String("result"))

pullDurationMetric = metric.NewCumulativeDistribution("mon_proxy/pubsub/pull_duration",

"Time taken to Pull messages from pub/sub, in milliseconds",

+ types.MetricMetadata{Units: types.Milliseconds},

distribution.DefaultBucketer)

ackDurationMetric = metric.NewCumulativeDistribution("mon_proxy/pubsub/ack_duration",

"Time taken to Ack messages to pub/sub, in milliseconds",

+ types.MetricMetadata{Units: types.Milliseconds},

distribution.DefaultBucketer)

)

« no previous file with comments | « go/src/infra/monitoring/proxy/main.go ('k') | go/src/infra/tools/cloudtail/client.go » ('j') | no next file with comments »