Reland of In official builds, let CHECK(false) crash instead of calling BreakDebugger.

Reland of In official builds, let CHECK(false) crash instead of calling BreakDebugger. (https://codereview.chromium.org/2046593002/ )

Reason for relanding:
The SIGTRAP support has landed in breakpad (https://codereview.chromium.org/2068673002)
and the crash reports seem to flow through correctly. Should now be safe to rely on
__builtin_trap() on arm64.

Original issue's description:
> Revert of In official builds, let CHECK(false) crash instead of calling BreakDebugger. (patchset #2 id:20001 of https://codereview.chromium.org/1982123002/ )
>
> Reason for revert:
> Unfortunately crrev.com/1982123002 causes loss of
> crash reports on Android arm64 (and supposedly also CrOS).
> This is because __builtin_trap() raises a SIGILL on x86 and
> arm but SIGTRAP on arm64. Breakpad does not handle SIGTRAP (yet).
> Temporarily reverting this CL until SIGTRAP support for breakpad lands.
>
> BUG=599867, 614865
>
> Original issue's description:
> > In official builds, let CHECK(false) crash instead of calling BreakDebugger.
> >
> > This should save some binary size and make things a bit faster, without ill
> > effects.
> >
> > See bug comment 15, and brettw's and my comments on
> > "[blink-dev] Update of wtf/Assertions.h, and ASSERT macros deprecation"
> >
> > BUG=599867
> >
> > Committed: https://crrev.com/481a8ec8b24df24795c63fd4ec26f3670d516db8
> > Cr-Commit-Position: refs/heads/master@{#394035}
>
> TBR=danakj@chromium.org,thakis@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=599867
>
> Committed: https://crrev.com/6ff194f572f62ff4989aaadc9af6616eb78b954a
> Cr-Commit-Position: refs/heads/master@{#398084}

BUG=599867, 614865
Committed: https://crrev.com/ba910a65a5a63594dc8558b337c3cb12028bc4fd
Cr-Commit-Position: refs/heads/master@{#404249}

[Primiano Tucci (use gerrit), 2016-07-06 17:23:46]

Created Reland of In official builds, let CHECK(false) crash instead of calling
BreakDebugger.

[Primiano Tucci (use gerrit), 2016-07-06 17:24:50]

Description was changed from

==========
Reland of In official builds, let CHECK(false) crash instead of calling
BreakDebugger. (patchset #1 id:1 of https://codereview.chromium.org/2046593002/
)

Reason for revert:
The SIGTRAP support has landed in breakpad and the crash reports seem to flow
through.
Should now be safe to rely on __builtin_trap on arm64.

Original issue's description:
> Revert of In official builds, let CHECK(false) crash instead of calling
BreakDebugger. (patchset #2 id:20001 of
https://codereview.chromium.org/1982123002/ )
> 
> Reason for revert:
> Unfortunately crrev.com/1982123002 causes loss of
> crash reports on Android arm64 (and supposedly also CrOS).
> This is because __builtin_trap() raises a SIGILL on x86 and
> arm but SIGTRAP on arm64. Breakpad does not handle SIGTRAP (yet).
> Temporarily reverting this CL until SIGTRAP support for breakpad lands.
> 
> BUG=599867,614865
> 
> Original issue's description:
> > In official builds, let CHECK(false) crash instead of calling BreakDebugger.
> >
> > This should save some binary size and make things a bit faster, without ill
> > effects.
> >
> > See bug comment 15, and brettw's and my comments on
> > "[blink-dev] Update of wtf/Assertions.h, and ASSERT macros deprecation"
> >
> > BUG=599867
> >
> > Committed: https://crrev.com/481a8ec8b24df24795c63fd4ec26f3670d516db8
> > Cr-Commit-Position: refs/heads/master@{#394035}
> 
> TBR=danakj@chromium.org,thakis@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=599867
> 
> Committed: https://crrev.com/6ff194f572f62ff4989aaadc9af6616eb78b954a
> Cr-Commit-Position: refs/heads/master@{#398084}

TBR=danakj@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=599867,614865
==========

to

==========
Reland of In official builds, let CHECK(false) crash instead of calling
BreakDebugger. (https://codereview.chromium.org/2046593002/ )

Reason for relanding:
The SIGTRAP support has landed in breakpad
(https://codereview.chromium.org/2068673002)
and the crash reports seem to flow through correctly. Should now be safe to rely
on
__builtin_trap() on arm64.

Original issue's description:
> Revert of In official builds, let CHECK(false) crash instead of calling
BreakDebugger. (patchset #2 id:20001 of
https://codereview.chromium.org/1982123002/ )
> 
> Reason for revert:
> Unfortunately crrev.com/1982123002 causes loss of
> crash reports on Android arm64 (and supposedly also CrOS).
> This is because __builtin_trap() raises a SIGILL on x86 and
> arm but SIGTRAP on arm64. Breakpad does not handle SIGTRAP (yet).
> Temporarily reverting this CL until SIGTRAP support for breakpad lands.
> 
> BUG=599867,614865
> 
> Original issue's description:
> > In official builds, let CHECK(false) crash instead of calling BreakDebugger.
> >
> > This should save some binary size and make things a bit faster, without ill
> > effects.
> >
> > See bug comment 15, and brettw's and my comments on
> > "[blink-dev] Update of wtf/Assertions.h, and ASSERT macros deprecation"
> >
> > BUG=599867
> >
> > Committed: https://crrev.com/481a8ec8b24df24795c63fd4ec26f3670d516db8
> > Cr-Commit-Position: refs/heads/master@{#394035}
> 
> TBR=danakj@chromium.org,thakis@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=599867
> 
> Committed: https://crrev.com/6ff194f572f62ff4989aaadc9af6616eb78b954a
> Cr-Commit-Position: refs/heads/master@{#398084}

TBR=danakj@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=599867,614865
==========

[Primiano Tucci (use gerrit), 2016-07-06 17:25:26]

Description was changed from

==========
Reland of In official builds, let CHECK(false) crash instead of calling
BreakDebugger. (https://codereview.chromium.org/2046593002/ )

Reason for relanding:
The SIGTRAP support has landed in breakpad
(https://codereview.chromium.org/2068673002)
and the crash reports seem to flow through correctly. Should now be safe to rely
on
__builtin_trap() on arm64.

Original issue's description:
> Revert of In official builds, let CHECK(false) crash instead of calling
BreakDebugger. (patchset #2 id:20001 of
https://codereview.chromium.org/1982123002/ )
> 
> Reason for revert:
> Unfortunately crrev.com/1982123002 causes loss of
> crash reports on Android arm64 (and supposedly also CrOS).
> This is because __builtin_trap() raises a SIGILL on x86 and
> arm but SIGTRAP on arm64. Breakpad does not handle SIGTRAP (yet).
> Temporarily reverting this CL until SIGTRAP support for breakpad lands.
> 
> BUG=599867,614865
> 
> Original issue's description:
> > In official builds, let CHECK(false) crash instead of calling BreakDebugger.
> >
> > This should save some binary size and make things a bit faster, without ill
> > effects.
> >
> > See bug comment 15, and brettw's and my comments on
> > "[blink-dev] Update of wtf/Assertions.h, and ASSERT macros deprecation"
> >
> > BUG=599867
> >
> > Committed: https://crrev.com/481a8ec8b24df24795c63fd4ec26f3670d516db8
> > Cr-Commit-Position: refs/heads/master@{#394035}
> 
> TBR=danakj@chromium.org,thakis@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=599867
> 
> Committed: https://crrev.com/6ff194f572f62ff4989aaadc9af6616eb78b954a
> Cr-Commit-Position: refs/heads/master@{#398084}

TBR=danakj@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=599867,614865
==========

to

==========
Reland of In official builds, let CHECK(false) crash instead of calling
BreakDebugger. (https://codereview.chromium.org/2046593002/ )

Reason for relanding:
The SIGTRAP support has landed in breakpad
(https://codereview.chromium.org/2068673002)
and the crash reports seem to flow through correctly. Should now be safe to rely
on
__builtin_trap() on arm64.

Original issue's description:
> Revert of In official builds, let CHECK(false) crash instead of calling
BreakDebugger. (patchset #2 id:20001 of
https://codereview.chromium.org/1982123002/ )
> 
> Reason for revert:
> Unfortunately crrev.com/1982123002 causes loss of
> crash reports on Android arm64 (and supposedly also CrOS).
> This is because __builtin_trap() raises a SIGILL on x86 and
> arm but SIGTRAP on arm64. Breakpad does not handle SIGTRAP (yet).
> Temporarily reverting this CL until SIGTRAP support for breakpad lands.
> 
> BUG=599867,614865
> 
> Original issue's description:
> > In official builds, let CHECK(false) crash instead of calling BreakDebugger.
> >
> > This should save some binary size and make things a bit faster, without ill
> > effects.
> >
> > See bug comment 15, and brettw's and my comments on
> > "[blink-dev] Update of wtf/Assertions.h, and ASSERT macros deprecation"
> >
> > BUG=599867
> >
> > Committed: https://crrev.com/481a8ec8b24df24795c63fd4ec26f3670d516db8
> > Cr-Commit-Position: refs/heads/master@{#394035}
> 
> TBR=danakj@chromium.org,thakis@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=599867
> 
> Committed: https://crrev.com/6ff194f572f62ff4989aaadc9af6616eb78b954a
> Cr-Commit-Position: refs/heads/master@{#398084}

BUG=599867,614865
==========

[Primiano Tucci (use gerrit), 2016-07-06 17:25:51]

Nico/Dana is it still safe to reland this as-is?
From the crash reporting perspective everything should be fine.

[Nico, 2016-07-06 17:44:07]

lgtm, thanks!

[Primiano Tucci (use gerrit), 2016-07-07 15:49:49]

The CQ bit was checked by primiano@chromium.org

[commit-bot: I haz the power, 2016-07-07 15:50:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 22:15:03]

Description was changed from

==========
Reland of In official builds, let CHECK(false) crash instead of calling
BreakDebugger. (https://codereview.chromium.org/2046593002/ )

Reason for relanding:
The SIGTRAP support has landed in breakpad
(https://codereview.chromium.org/2068673002)
and the crash reports seem to flow through correctly. Should now be safe to rely
on
__builtin_trap() on arm64.

Original issue's description:
> Revert of In official builds, let CHECK(false) crash instead of calling
BreakDebugger. (patchset #2 id:20001 of
https://codereview.chromium.org/1982123002/ )
> 
> Reason for revert:
> Unfortunately crrev.com/1982123002 causes loss of
> crash reports on Android arm64 (and supposedly also CrOS).
> This is because __builtin_trap() raises a SIGILL on x86 and
> arm but SIGTRAP on arm64. Breakpad does not handle SIGTRAP (yet).
> Temporarily reverting this CL until SIGTRAP support for breakpad lands.
> 
> BUG=599867,614865
> 
> Original issue's description:
> > In official builds, let CHECK(false) crash instead of calling BreakDebugger.
> >
> > This should save some binary size and make things a bit faster, without ill
> > effects.
> >
> > See bug comment 15, and brettw's and my comments on
> > "[blink-dev] Update of wtf/Assertions.h, and ASSERT macros deprecation"
> >
> > BUG=599867
> >
> > Committed: https://crrev.com/481a8ec8b24df24795c63fd4ec26f3670d516db8
> > Cr-Commit-Position: refs/heads/master@{#394035}
> 
> TBR=danakj@chromium.org,thakis@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=599867
> 
> Committed: https://crrev.com/6ff194f572f62ff4989aaadc9af6616eb78b954a
> Cr-Commit-Position: refs/heads/master@{#398084}

BUG=599867,614865
==========

to

==========
Reland of In official builds, let CHECK(false) crash instead of calling
BreakDebugger. (https://codereview.chromium.org/2046593002/ )

Reason for relanding:
The SIGTRAP support has landed in breakpad
(https://codereview.chromium.org/2068673002)
and the crash reports seem to flow through correctly. Should now be safe to rely
on
__builtin_trap() on arm64.

Original issue's description:
> Revert of In official builds, let CHECK(false) crash instead of calling
BreakDebugger. (patchset #2 id:20001 of
https://codereview.chromium.org/1982123002/ )
> 
> Reason for revert:
> Unfortunately crrev.com/1982123002 causes loss of
> crash reports on Android arm64 (and supposedly also CrOS).
> This is because __builtin_trap() raises a SIGILL on x86 and
> arm but SIGTRAP on arm64. Breakpad does not handle SIGTRAP (yet).
> Temporarily reverting this CL until SIGTRAP support for breakpad lands.
> 
> BUG=599867,614865
> 
> Original issue's description:
> > In official builds, let CHECK(false) crash instead of calling BreakDebugger.
> >
> > This should save some binary size and make things a bit faster, without ill
> > effects.
> >
> > See bug comment 15, and brettw's and my comments on
> > "[blink-dev] Update of wtf/Assertions.h, and ASSERT macros deprecation"
> >
> > BUG=599867
> >
> > Committed: https://crrev.com/481a8ec8b24df24795c63fd4ec26f3670d516db8
> > Cr-Commit-Position: refs/heads/master@{#394035}
> 
> TBR=danakj@chromium.org,thakis@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=599867
> 
> Committed: https://crrev.com/6ff194f572f62ff4989aaadc9af6616eb78b954a
> Cr-Commit-Position: refs/heads/master@{#398084}

BUG=599867,614865
==========

[commit-bot: I haz the power, 2016-07-07 22:15:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-07 22:17:20]

Description was changed from

==========
Reland of In official builds, let CHECK(false) crash instead of calling
BreakDebugger. (https://codereview.chromium.org/2046593002/ )

Reason for relanding:
The SIGTRAP support has landed in breakpad
(https://codereview.chromium.org/2068673002)
and the crash reports seem to flow through correctly. Should now be safe to rely
on
__builtin_trap() on arm64.

Original issue's description:
> Revert of In official builds, let CHECK(false) crash instead of calling
BreakDebugger. (patchset #2 id:20001 of
https://codereview.chromium.org/1982123002/ )
> 
> Reason for revert:
> Unfortunately crrev.com/1982123002 causes loss of
> crash reports on Android arm64 (and supposedly also CrOS).
> This is because __builtin_trap() raises a SIGILL on x86 and
> arm but SIGTRAP on arm64. Breakpad does not handle SIGTRAP (yet).
> Temporarily reverting this CL until SIGTRAP support for breakpad lands.
> 
> BUG=599867,614865
> 
> Original issue's description:
> > In official builds, let CHECK(false) crash instead of calling BreakDebugger.
> >
> > This should save some binary size and make things a bit faster, without ill
> > effects.
> >
> > See bug comment 15, and brettw's and my comments on
> > "[blink-dev] Update of wtf/Assertions.h, and ASSERT macros deprecation"
> >
> > BUG=599867
> >
> > Committed: https://crrev.com/481a8ec8b24df24795c63fd4ec26f3670d516db8
> > Cr-Commit-Position: refs/heads/master@{#394035}
> 
> TBR=danakj@chromium.org,thakis@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=599867
> 
> Committed: https://crrev.com/6ff194f572f62ff4989aaadc9af6616eb78b954a
> Cr-Commit-Position: refs/heads/master@{#398084}

BUG=599867,614865
==========

to

==========
Reland of In official builds, let CHECK(false) crash instead of calling
BreakDebugger. (https://codereview.chromium.org/2046593002/ )

Reason for relanding:
The SIGTRAP support has landed in breakpad
(https://codereview.chromium.org/2068673002)
and the crash reports seem to flow through correctly. Should now be safe to rely
on
__builtin_trap() on arm64.

Original issue's description:
> Revert of In official builds, let CHECK(false) crash instead of calling
BreakDebugger. (patchset #2 id:20001 of
https://codereview.chromium.org/1982123002/ )
>
> Reason for revert:
> Unfortunately crrev.com/1982123002 causes loss of
> crash reports on Android arm64 (and supposedly also CrOS).
> This is because __builtin_trap() raises a SIGILL on x86 and
> arm but SIGTRAP on arm64. Breakpad does not handle SIGTRAP (yet).
> Temporarily reverting this CL until SIGTRAP support for breakpad lands.
>
> BUG=599867,614865
>
> Original issue's description:
> > In official builds, let CHECK(false) crash instead of calling BreakDebugger.
> >
> > This should save some binary size and make things a bit faster, without ill
> > effects.
> >
> > See bug comment 15, and brettw's and my comments on
> > "[blink-dev] Update of wtf/Assertions.h, and ASSERT macros deprecation"
> >
> > BUG=599867
> >
> > Committed: https://crrev.com/481a8ec8b24df24795c63fd4ec26f3670d516db8
> > Cr-Commit-Position: refs/heads/master@{#394035}
>
> TBR=danakj@chromium.org,thakis@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=599867
>
> Committed: https://crrev.com/6ff194f572f62ff4989aaadc9af6616eb78b954a
> Cr-Commit-Position: refs/heads/master@{#398084}

BUG=599867,614865

Committed: https://crrev.com/ba910a65a5a63594dc8558b337c3cb12028bc4fd
Cr-Commit-Position: refs/heads/master@{#404249}
==========

[commit-bot: I haz the power, 2016-07-07 22:17:21]

Patchset 1 (id:??) landed as
https://crrev.com/ba910a65a5a63594dc8558b337c3cb12028bc4fd
Cr-Commit-Position: refs/heads/master@{#404249}