Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 2068673002: Roll src/breakpad/src/ 1c3361fcc..957b22c62 (3 commits). SIGTRAP handling. (Closed)

Created:
4 years, 6 months ago by Primiano Tucci (use gerrit)
Modified:
4 years, 6 months ago
Reviewers:
Mark Mentovai, Nico
CC:
chromium-reviews, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll src/breakpad/src/ 1c3361fcc..957b22c62 (3 commits). SIGTRAP handling. https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/1c3361fcc256..957b22c6256c $ git log 1c3361fcc..957b22c62 --date=short --no-merges --format='%ad %ae %s' 2016-06-10 nnethercote Fix a trivial parsing bug caught by static analysis R=ted 2016-06-10 giles Update symbol file documentation links. 2016-06-08 primiano linux/android: add SIGTRAP to the list of signals handled by the client Note for stability sheriffs: ---------------------------- This is rolling a breakpad change which causes to report also crashes triggered by SIGTRAP. This will have a large visible effect on our crash collection on Linux/Android/CrOS. The main effect I expect is a lot more of renderer crashes on arm64. This would be WAI and would essentially give us back all the crashes we lost so far on arm64. Any other change, instead, should be more carefully investigated, especially if the number of reported crashes reduces instead. BUG=614865 Committed: https://crrev.com/8e28db059cec586307011a703f0c751c8c706f69 Cr-Commit-Position: refs/heads/master@{#399700}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Primiano Tucci (use gerrit)
Mark, PTAL and wish me good luck as this will likely cause me to get ...
4 years, 6 months ago (2016-06-14 12:19:10 UTC) #3
Nico
lgtm, sounds good, good luck!
4 years, 6 months ago (2016-06-14 12:21:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068673002/1
4 years, 6 months ago (2016-06-14 14:29:29 UTC) #7
Mark Mentovai
LGTM. Good luck. Pro tip: set up a Gmail filter to auto-archive anything that mentions ...
4 years, 6 months ago (2016-06-14 14:31:02 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 14:34:53 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 14:36:35 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e28db059cec586307011a703f0c751c8c706f69
Cr-Commit-Position: refs/heads/master@{#399700}

Powered by Google App Engine
This is Rietveld 408576698