In official builds, let CHECK(false) crash instead of calling BreakDebugger.

In official builds, let CHECK(false) crash instead of calling BreakDebugger.

This should save some binary size and make things a bit faster, without ill
effects.

See bug comment 15, and brettw's and my comments on
"[blink-dev] Update of wtf/Assertions.h, and ASSERT macros deprecation"

BUG=599867
Committed: https://crrev.com/481a8ec8b24df24795c63fd4ec26f3670d516db8
Cr-Commit-Position: refs/heads/master@{#394035}

[Nico, 2016-05-16 23:41:03]

thakis@chromium.org changed reviewers:
+ danakj@chromium.org

[Nico, 2016-05-16 23:41:04]

I sadly noticed the "BreadDebugger" typo and will now have to fix it :-(

[Nico, 2016-05-16 23:41:15]

Description was changed from

==========
In official builds, let CHECK(false) crash instead of calling BreadDebugger.

This should save some binary size and make things a bit faster, without ill
effects.

See bug comment 15, and brettw's and my comments on
"[blink-dev] Update of wtf/Assertions.h, and ASSERT macros deprecation"

BUG=599867
==========

to

==========
In official builds, let CHECK(false) crash instead of calling BreakDebugger.

This should save some binary size and make things a bit faster, without ill
effects.

See bug comment 15, and brettw's and my comments on
"[blink-dev] Update of wtf/Assertions.h, and ASSERT macros deprecation"

BUG=599867
==========

[danakj, 2016-05-16 23:43:11]

BreadDebugger forever. LGTM

https://codereview.chromium.org/1982123002/diff/1/base/logging.h
File base/logging.h (right):

https://codereview.chromium.org/1982123002/diff/1/base/logging.h#newcode456
base/logging.h:456: #if defined(COMPILER_GCC) || __clang__
Can you leave a comment saying this is explicitly not doing BreakDebugger?

[Nico, 2016-05-16 23:44:51]

The CQ bit was checked by thakis@chromium.org

[Nico, 2016-05-16 23:44:51]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1982123002/#ps20001
(title: "comment")

[commit-bot: I haz the power, 2016-05-16 23:45:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1982123002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1982123002/20001

[commit-bot: I haz the power, 2016-05-17 03:09:42]

Description was changed from

==========
In official builds, let CHECK(false) crash instead of calling BreakDebugger.

This should save some binary size and make things a bit faster, without ill
effects.

See bug comment 15, and brettw's and my comments on
"[blink-dev] Update of wtf/Assertions.h, and ASSERT macros deprecation"

BUG=599867
==========

to

==========
In official builds, let CHECK(false) crash instead of calling BreakDebugger.

This should save some binary size and make things a bit faster, without ill
effects.

See bug comment 15, and brettw's and my comments on
"[blink-dev] Update of wtf/Assertions.h, and ASSERT macros deprecation"

BUG=599867
==========

[commit-bot: I haz the power, 2016-05-17 03:09:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-17 03:12:26]

Description was changed from

==========
In official builds, let CHECK(false) crash instead of calling BreakDebugger.

This should save some binary size and make things a bit faster, without ill
effects.

See bug comment 15, and brettw's and my comments on
"[blink-dev] Update of wtf/Assertions.h, and ASSERT macros deprecation"

BUG=599867
==========

to

==========
In official builds, let CHECK(false) crash instead of calling BreakDebugger.

This should save some binary size and make things a bit faster, without ill
effects.

See bug comment 15, and brettw's and my comments on
"[blink-dev] Update of wtf/Assertions.h, and ASSERT macros deprecation"

BUG=599867

Committed: https://crrev.com/481a8ec8b24df24795c63fd4ec26f3670d516db8
Cr-Commit-Position: refs/heads/master@{#394035}
==========

[commit-bot: I haz the power, 2016-05-17 03:12:27]

Patchset 2 (id:??) landed as
https://crrev.com/481a8ec8b24df24795c63fd4ec26f3670d516db8
Cr-Commit-Position: refs/heads/master@{#394035}

[Primiano Tucci (use gerrit), 2016-06-06 14:58:09]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2046593002/ by primiano@chromium.org.

The reason for reverting is: Unfortunately crrev.com/1982123002 causes loss of
crash reports on Android arm64 (and supposedly also CrOS).
This is because __builtin_trap() raises a SIGILL on x86 and
arm but SIGTRAP on arm64. Breakpad does not handle SIGTRAP (yet).
Temporarily reverting this CL until SIGTRAP support for breakpad lands.


BUG=599867,614865.

[Nico, 2016-12-02 15:29:00]

Maybe we should just call abort(). That's marked noreturn, takes 0 arguments,
and is standard. What was the problem with that again? (I guess the compiler
could still collect all calls to abort in a function in one basic block and just
jump to that from everywhere, like with __builtin_trap?)

[Nico, 2016-12-02 15:29:17]

On 2016/12/02 15:29:00, Nico wrote:
> Maybe we should just call abort(). That's marked noreturn, takes 0 arguments,
> and is standard. What was the problem with that again? (I guess the compiler
> could still collect all calls to abort in a function in one basic block and
just
> jump to that from everywhere, like with __builtin_trap?)

Err sorry that was for a different issue.