Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2125423002: [DevTools] Rename ScriptPosition.line|column into lineNumber|columnNumber (Closed)

Created:
4 years, 5 months ago by kozy
Modified:
4 years, 5 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Rename ScriptPosition.line|column into lineNumber|columnNumber R=dgozman@chromium.org Committed: https://crrev.com/d745e7890a29a4ebc387c255611574770b9f0eea Cr-Commit-Position: refs/heads/master@{#404549}

Patch Set 1 #

Messages

Total messages: 14 (6 generated)
kozy
Dmitry, ptal
4 years, 5 months ago (2016-07-07 21:21:52 UTC) #1
dgozman
lgtm
4 years, 5 months ago (2016-07-08 20:22:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125423002/1
4 years, 5 months ago (2016-07-08 20:34:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/252445)
4 years, 5 months ago (2016-07-08 23:08:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125423002/1
4 years, 5 months ago (2016-07-08 23:28:42 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-09 00:43:02 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-09 00:43:05 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-09 00:45:03 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d745e7890a29a4ebc387c255611574770b9f0eea
Cr-Commit-Position: refs/heads/master@{#404549}

Powered by Google App Engine
This is Rietveld 408576698