Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js

Issue 2125423002: [DevTools] Rename ScriptPosition.line|column into lineNumber|columnNumber (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js b/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js
index 5d1628fb4d64629cc8d0c0ac557e0b2f5cbe8ed8..4492c4e376abcdcc7f2feb0bbd524cb409dfe5ea 100644
--- a/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js
@@ -98,9 +98,9 @@ WebInspector.BlackboxManager.prototype = {
*/
function comparator(a, b)
{
- if (a.lineNumber !== b.line)
- return a.lineNumber - b.line;
- return a.columnNumber - b.column;
+ if (a.lineNumber !== b.lineNumber)
+ return a.lineNumber - b.lineNumber;
+ return a.columnNumber - b.columnNumber;
}
},
@@ -162,12 +162,12 @@ WebInspector.BlackboxManager.prototype = {
var positions = [];
// If content in script file begin is not mapped and one or more ranges are blackboxed then blackbox it.
if (mappings[0].lineNumber !== 0 || mappings[0].columnNumber !== 0) {
- positions.push({ line: 0, column: 0});
+ positions.push({ lineNumber: 0, columnNumber: 0});
currentBlackboxed = true;
}
for (var mapping of mappings) {
if (mapping.sourceURL && currentBlackboxed !== this.isBlackboxedURL(mapping.sourceURL)) {
- positions.push({ line: mapping.lineNumber, column: mapping.columnNumber });
+ positions.push({ lineNumber: mapping.lineNumber, columnNumber: mapping.columnNumber });
currentBlackboxed = !currentBlackboxed;
}
isBlackboxed = currentBlackboxed || isBlackboxed;
@@ -346,7 +346,7 @@ WebInspector.BlackboxManager.prototype = {
_addScript: function(script)
{
var blackboxed = this._isBlackboxedScript(script);
- return this._setScriptState(script, blackboxed ? [ { line: 0, column: 0 } ] : []);
+ return this._setScriptState(script, blackboxed ? [ { lineNumber: 0, columnNumber: 0 } ] : []);
},
/**
@@ -393,7 +393,7 @@ WebInspector.BlackboxManager.prototype = {
var hasChanged = false;
hasChanged = previousScriptState.length !== positions.length;
for (var i = 0; !hasChanged && i < positions.length; ++i)
- hasChanged = positions[i].line !== previousScriptState[i].line || positions[i].column !== previousScriptState[i].column;
+ hasChanged = positions[i].lineNumber !== previousScriptState[i].lineNumber || positions[i].columnNumber !== previousScriptState[i].columnNumber;
if (!hasChanged)
return Promise.resolve();
} else {

Powered by Google App Engine
This is Rietveld 408576698