third_party/WebKit/LayoutTests/inspector-protocol/debugger/stepping-with-blackboxed-ranges.html - Issue 2125423002: [DevTools] Rename ScriptPosition.line|column into lineNumber|columnNumber

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector-protocol/debugger/stepping-with-blackboxed-ranges.html

Issue 2125423002: [DevTools] Rename ScriptPosition.line|column into lineNumber|columnNumber (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector-protocol/debugger/stepping-with-blackboxed-ranges-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector-protocol/debugger/stepping-with-blackboxed-ranges.html

diff --git a/third_party/WebKit/LayoutTests/inspector-protocol/debugger/stepping-with-blackboxed-ranges.html b/third_party/WebKit/LayoutTests/inspector-protocol/debugger/stepping-with-blackboxed-ranges.html

index e31f5967256066e6ecd2de62c035983efa50f194..bdce550dfdd94fd08fcda158020b62f6da813bd3 100644

--- a/third_party/WebKit/LayoutTests/inspector-protocol/debugger/stepping-with-blackboxed-ranges.html

+++ b/third_party/WebKit/LayoutTests/inspector-protocol/debugger/stepping-with-blackboxed-ranges.html

@@ -33,14 +33,14 @@ function test()

printCallFrames(callFrames);

InspectorTest.sendCommand("Debugger.setBlackboxedRanges", {

scriptId: callFrames[1].location.scriptId,

- positions: [ { line: 0, column: 0 } ] // blackbox ranges for blackboxed.js

+ positions: [ { lineNumber: 0, columnNumber: 0 } ] // blackbox ranges for blackboxed.js

}, setIncorrectRanges.bind(null, callFrames[2].location.scriptId));

}

var incorrectPositions = [

- [ { line: 0, column: 0 }, { line: 0, column: 0 } ],

- [ { line: 0, column: 1 }, { line: 0, column: 0 } ],

- [ { line: 0, column: -1 } ],

+ [ { lineNumber: 0, columnNumber: 0 }, { lineNumber: 0, columnNumber: 0 } ],

+ [ { lineNumber: 0, columnNumber: 1 }, { lineNumber: 0, columnNumber: 0 } ],

+ [ { lineNumber: 0, columnNumber: -1 } ],

];

function setIncorrectRanges(scriptId, response)

@@ -64,7 +64,7 @@ function test()

InspectorTest.eventHandler["Debugger.paused"] = runAction;

InspectorTest.sendCommandOrDie("Debugger.setBlackboxedRanges", {

scriptId: scriptId,

- positions: [ { line: 8, column: 0 }, { line: 15, column: 0 } ] // blackbox ranges for mixed.js

+ positions: [ { lineNumber: 8, columnNumber: 0 }, { lineNumber: 15, columnNumber: 0 } ] // blackbox ranges for mixed.js

}, runAction);

}