Fix a problem with duplicate calls to FrameFetchContext::dispatchDidFail

Fix a problem with duplicate calls to FrameFetchContext::dispatchDidFail

In some circumstances FrameFetchContext::dispatchDidFail can get called
twice for the same resource.  This patch fixes an assumption by the
blink scheduler that this scenario didn't happen.

BUG=626218
Committed: https://crrev.com/4c316c6a98fd2e49bd92c3d90855cffc57df3608
Cr-Commit-Position: refs/heads/master@{#404191}

[alex clarke (OOO till 29th), 2016-07-07 11:02:18]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-07 11:02:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alex clarke (OOO till 29th), 2016-07-07 11:03:44]

alexclarke@chromium.org changed reviewers:
+ jochen@chromium.org, skyostil@chromium.org

[alex clarke (OOO till 29th), 2016-07-07 11:03:45]

PTAL

[Sami, 2016-07-07 11:21:40]

lgtm

https://codereview.chromium.org/2125273002/diff/1/components/scheduler/render...
File components/scheduler/renderer/web_view_scheduler_impl.h (right):

https://codereview.chromium.org/2125273002/diff/1/components/scheduler/render...
components/scheduler/renderer/web_view_scheduler_impl.h:71: std::set<unsigned
long> pending_fetches_;
naming nit: how about pending_loads_ to keep the terminology consistent?

[alex clarke (OOO till 29th), 2016-07-07 12:10:04]

https://codereview.chromium.org/2125273002/diff/1/components/scheduler/render...
File components/scheduler/renderer/web_view_scheduler_impl.h (right):

https://codereview.chromium.org/2125273002/diff/1/components/scheduler/render...
components/scheduler/renderer/web_view_scheduler_impl.h:71: std::set<unsigned
long> pending_fetches_;
On 2016/07/07 11:21:40, Sami wrote:
> naming nit: how about pending_loads_ to keep the terminology consistent?

Done.

[jochen (gone - plz use gerrit), 2016-07-07 14:05:41]

lgtm

[alex clarke (OOO till 29th), 2016-07-07 14:06:09]

The CQ bit was checked by alexclarke@chromium.org

[alex clarke (OOO till 29th), 2016-07-07 14:06:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2125273002/#ps20001
(title: "Rename the set")

[commit-bot: I haz the power, 2016-07-07 14:06:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 16:07:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 16:08:00]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[alex clarke (OOO till 29th), 2016-07-07 16:08:36]

The CQ bit was checked by alexclarke@chromium.org

[commit-bot: I haz the power, 2016-07-07 16:09:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 18:49:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-07 18:49:51]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-07 18:51:43]

Description was changed from

==========
Fix a problem with duplicate calls to FrameFetchContext::dispatchDidFail

In some circumstances FrameFetchContext::dispatchDidFail can get called
twice for the same resource.  This patch fixes an assumption by the
blink scheduler that this scenario didn't happen.

BUG=626218
==========

to

==========
Fix a problem with duplicate calls to FrameFetchContext::dispatchDidFail

In some circumstances FrameFetchContext::dispatchDidFail can get called
twice for the same resource.  This patch fixes an assumption by the
blink scheduler that this scenario didn't happen.

BUG=626218

Committed: https://crrev.com/4c316c6a98fd2e49bd92c3d90855cffc57df3608
Cr-Commit-Position: refs/heads/master@{#404191}
==========

[commit-bot: I haz the power, 2016-07-07 18:51:45]

Patchset 2 (id:??) landed as
https://crrev.com/4c316c6a98fd2e49bd92c3d90855cffc57df3608
Cr-Commit-Position: refs/heads/master@{#404191}