components/scheduler/renderer/web_view_scheduler_impl.h - Issue 2125273002: Fix a problem with duplicate calls to FrameFetchContext::dispatchDidFail

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/scheduler/renderer/web_view_scheduler_impl.h

Issue 2125273002: Fix a problem with duplicate calls to FrameFetchContext::dispatchDidFail (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rename the set Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/scheduler/renderer/web_frame_scheduler_impl.cc ('k') | components/scheduler/renderer/web_view_scheduler_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/scheduler/renderer/web_view_scheduler_impl.h

diff --git a/components/scheduler/renderer/web_view_scheduler_impl.h b/components/scheduler/renderer/web_view_scheduler_impl.h

index 233c1dc29b2c6c561c239e61e05ccf42713360bf..019696c8e57256b07af1d52ed36c1f7cf6e94293 100644

--- a/components/scheduler/renderer/web_view_scheduler_impl.h

+++ b/components/scheduler/renderer/web_view_scheduler_impl.h

@@ -53,8 +53,8 @@ class SCHEDULER_EXPORT WebViewSchedulerImpl : public blink::WebViewScheduler {

std::unique_ptr<WebFrameSchedulerImpl> createWebFrameSchedulerImpl(

base::trace_event::BlameContext* blame_context);

- void incrementPendingResourceLoadCount();

- void decrementPendingResourceLoadCount();

+ void DidStartLoading(unsigned long identifier);

+ void DidStopLoading(unsigned long identifier);

private:

friend class WebFrameSchedulerImpl;

@@ -68,11 +68,11 @@ class SCHEDULER_EXPORT WebViewSchedulerImpl : public blink::WebViewScheduler {

void setAllowVirtualTimeToAdvance(bool allow_virtual_time_to_advance);

std::set<WebFrameSchedulerImpl*> frame_schedulers_;

+ std::set<unsigned long> pending_loads_;

std::unique_ptr<AutoAdvancingVirtualTimeDomain> virtual_time_domain_;

TaskQueue::PumpPolicy virtual_time_pump_policy_;

blink::WebView* web_view_;

RendererSchedulerImpl* renderer_scheduler_;

- int pending_resource_load_count_;

VirtualTimePolicy virtual_time_policy_;

bool page_visible_;

bool disable_background_timer_throttling_;