Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: components/scheduler/renderer/web_view_scheduler_impl_unittest.cc

Issue 2125273002: Fix a problem with duplicate calls to FrameFetchContext::dispatchDidFail (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rename the set Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/scheduler/renderer/web_view_scheduler_impl_unittest.cc
diff --git a/components/scheduler/renderer/web_view_scheduler_impl_unittest.cc b/components/scheduler/renderer/web_view_scheduler_impl_unittest.cc
index 5a3d54751c7c0560de954d680b3b13d8228dbbd5..49bed4d1dd5cac814544cb7738b094ed6336ad51 100644
--- a/components/scheduler/renderer/web_view_scheduler_impl_unittest.cc
+++ b/components/scheduler/renderer/web_view_scheduler_impl_unittest.cc
@@ -508,22 +508,45 @@ TEST_F(WebViewSchedulerImplTest,
VirtualTimePolicy::PAUSE_IF_NETWORK_FETCHES_PENDING);
EXPECT_TRUE(web_view_scheduler_->virtualTimeAllowedToAdvance());
- web_view_scheduler_->incrementPendingResourceLoadCount();
+ web_view_scheduler_->DidStartLoading(1u);
EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());
- web_view_scheduler_->incrementPendingResourceLoadCount();
+ web_view_scheduler_->DidStartLoading(2u);
EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());
- web_view_scheduler_->decrementPendingResourceLoadCount();
+ web_view_scheduler_->DidStopLoading(2u);
EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());
- web_view_scheduler_->incrementPendingResourceLoadCount();
+ web_view_scheduler_->DidStartLoading(3u);
EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());
- web_view_scheduler_->decrementPendingResourceLoadCount();
+ web_view_scheduler_->DidStopLoading(1u);
EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());
- web_view_scheduler_->decrementPendingResourceLoadCount();
+ web_view_scheduler_->DidStopLoading(3u);
+ EXPECT_TRUE(web_view_scheduler_->virtualTimeAllowedToAdvance());
+}
+
+TEST_F(WebViewSchedulerImplTest, RedundantDidStopLoadingCallsAreHarmless) {
+ web_view_scheduler_->setVirtualTimePolicy(
+ VirtualTimePolicy::PAUSE_IF_NETWORK_FETCHES_PENDING);
+
+ web_view_scheduler_->DidStartLoading(1u);
+ EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());
+
+ web_view_scheduler_->DidStopLoading(1u);
+ EXPECT_TRUE(web_view_scheduler_->virtualTimeAllowedToAdvance());
+
+ web_view_scheduler_->DidStopLoading(1u);
+ EXPECT_TRUE(web_view_scheduler_->virtualTimeAllowedToAdvance());
+
+ web_view_scheduler_->DidStopLoading(1u);
+ EXPECT_TRUE(web_view_scheduler_->virtualTimeAllowedToAdvance());
+
+ web_view_scheduler_->DidStartLoading(2u);
+ EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());
+
+ web_view_scheduler_->DidStopLoading(2u);
EXPECT_TRUE(web_view_scheduler_->virtualTimeAllowedToAdvance());
}
« no previous file with comments | « components/scheduler/renderer/web_view_scheduler_impl.cc ('k') | third_party/WebKit/Source/core/loader/FrameFetchContext.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698