[IndexedDB] Propogating changes to observers : Renderer

third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp

Index: third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp
index fa8eda53199a792a5f9e622d354908b9379f16d1..6e235895630d0401c9e759b42cb8bf03c1d82632 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp
@@ -170,6 +170,13 @@ DOMStringList* IDBDatabase::objectStoreNames() const
     return objectStoreNames;
 }
 
+const String& IDBDatabase::getObjectStoreName(int64_t objectStoreId) const
+{
+    const auto& it = m_metadata.objectStores.find(objectStoreId);
+    SECURITY_DCHECK(it != m_metadata.objectStores.end());

[haraken, 2016/07/20 16:22:11]

SECURITY_DCHECK => DCHECK

I don't think this is security-sensitive.

[jsbell, 2016/07/20 17:18:31]

The objectStoreId in this case was sent browser->renderer; this could fail if
the process or IPC is compromised. Based on past guidance, we use
ASSERT_WITH_SECURITY_IMPLICATIONS (the old name for the macro) elsewhere for
similar cases.

But since we dereference `it` immediately (which will crash) I think it's OK to
change to a DCHECK.

[palakj1, 2016/07/20 18:22:11]

As re-confimred by jsbell, changing back to DCHECK.

+    return it->value.name;
+}
+
 IDBObjectStore* IDBDatabase::createObjectStore(const String& name, const IDBKeyPath& keyPath, bool autoIncrement, ExceptionState& exceptionState)
 {
     IDB_TRACE("IDBDatabase::createObjectStore");