third_party/WebKit/Source/modules/indexeddb/IDBObservation.h - Issue 2125213002: [IndexedDB] Propogating changes to observers : Renderer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBObservation.h

Issue 2125213002: [IndexedDB] Propogating changes to observers : Renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lifetime

Patch Set: Minor fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp ('K') | « third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp ('k') | third_party/WebKit/Source/modules/indexeddb/IDBObservation.cpp » ('j') | third_party/WebKit/Source/modules/indexeddb/IDBObservation.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/indexeddb/IDBObservation.h

diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBObservation.h b/third_party/WebKit/Source/modules/indexeddb/IDBObservation.h

index d94ee7c12ac87a107fe2243ff7f1c3a83c237c8d..95d64a90fcec5970105ee2e8ea19d1eee4590c05 100644

--- a/third_party/WebKit/Source/modules/indexeddb/IDBObservation.h

+++ b/third_party/WebKit/Source/modules/indexeddb/IDBObservation.h

@@ -13,16 +13,17 @@

namespace blink {

-class IDBKey;

+class IDBKeyRange;

class IDBValue;

class ScriptState;

+struct WebIDBObservation;

class IDBObservation final : public GarbageCollectedFinalized<IDBObservation>, public ScriptWrappable {

DEFINE_WRAPPERTYPEINFO();

public:

static WebIDBOperationType stringToOperationType(const String&);

- static IDBObservation* create(IDBKey*, PassRefPtr<IDBValue>, WebIDBOperationType);

+ static IDBObservation* create(const WebIDBObservation&);

~IDBObservation();

DECLARE_TRACE();

@@ -33,8 +34,8 @@ public:

const String& type() const;

private:

- IDBObservation(IDBKey*, PassRefPtr<IDBValue>, WebIDBOperationType);

- Member<IDBKey> m_key;

+ IDBObservation(const WebIDBObservation&);

+ Member<IDBKeyRange> m_keyRange;

RefPtr<IDBValue> m_value;

const WebIDBOperationType m_operationType;

};