[IndexedDB] Propogating changes to observers : Renderer

third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 152 matching lines @@
 
 DOMStringList* IDBDatabase::objectStoreNames() const
 {
     DOMStringList* objectStoreNames = DOMStringList::create(DOMStringList::IndexedDB);
     for (const auto& it : m_metadata.objectStores)
         objectStoreNames->append(it.value.name);
     objectStoreNames->sort();
     return objectStoreNames;
 }
 
+const String& IDBDatabase::getObjectStoreName(int64_t objectStoreId) const
+{
+    const auto& it = m_metadata.objectStores.find(objectStoreId);
+    SECURITY_DCHECK(it != m_metadata.objectStores.end());

[haraken, 2016/07/20 16:22:11]

SECURITY_DCHECK => DCHECK

I don't think this is security-sensitive.

[jsbell, 2016/07/20 17:18:31]

The objectStoreId in this case was sent browser->renderer; this could fail if
the process or IPC is compromised. Based on past guidance, we use
ASSERT_WITH_SECURITY_IMPLICATIONS (the old name for the macro) elsewhere for
similar cases.

But since we dereference `it` immediately (which will crash) I think it's OK to
change to a DCHECK.

[palakj1, 2016/07/20 18:22:11]

As re-confimred by jsbell, changing back to DCHECK.

+    return it->value.name;
+}
+
 IDBObjectStore* IDBDatabase::createObjectStore(const String& name, const IDBKeyPath& keyPath, bool autoIncrement, ExceptionState& exceptionState)
 {
     IDB_TRACE("IDBDatabase::createObjectStore");
     recordApiCallsHistogram(IDBCreateObjectStoreCall);
 
     if (!m_versionChangeTransaction) {
         exceptionState.throwDOMException(InvalidStateError, IDBDatabase::notVersionChangeTransactionErrorMessage);
         return nullptr;
     }
     if (m_versionChangeTransaction->isFinished() || m_versionChangeTransaction->isFinishing()) {
@@ skipping 264 matching lines @@
     return ActiveDOMObject::getExecutionContext();
 }
 
 void IDBDatabase::recordApiCallsHistogram(IndexedDatabaseMethods method)
 {
     DEFINE_THREAD_SAFE_STATIC_LOCAL(EnumerationHistogram, apiCallsHistogram, new EnumerationHistogram("WebCore.IndexedDB.FrontEndAPICalls", IDBMethodsMax));
     apiCallsHistogram.count(method);
 }
 
 } // namespace blink