third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.idl - Issue 2125213002: [IndexedDB] Propogating changes to observers : Renderer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.idl

Issue 2125213002: [IndexedDB] Propogating changes to observers : Renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lifetime

Patch Set: IDBDatabase weakptr introduced on IDBObserver Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.h ('K') | « third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.cpp ('k') | third_party/WebKit/Source/modules/indexeddb/IDBObserverChangesRecord.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.idl

diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.idl b/third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.idl

index 17f7a068c06c81660261b410c48c6df7b2bf17bc..b5d7f40ff15ad941317ffe2eff04e0189dc14aa5 100644

--- a/third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.idl

+++ b/third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.idl

@@ -13,8 +13,8 @@

readonly attribute IDBTransaction transaction;

// This is the javascript Map<String, sequence<IDBObserverChangesRecord>>,

// where the key is the object store name.

- // TODO(palakj) : Replace 'any' with maplike<DOMString, sequence<IDBObserverChangesRecord>>.

- [CallWith=ScriptState] readonly attribute any records;

+ // TODO(palakj) : Replace sequence<IDBObservation> with maplike<DOMString, sequence<IDBObserverChangesRecord>>.

+ [CallWith=ScriptState] readonly attribute sequence<IDBObservation> records;

Marijn Kruisselbrink 2016/07/11 23:10:40 (maybe not relevant if you're somehow changing thi

palakj1 2016/07/13 00:43:51 Changed this to 'any'.

};