third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.idl - Issue 2125213002: [IndexedDB] Propogating changes to observers : Renderer

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.idl

Issue 2125213002: [IndexedDB] Propogating changes to observers : Renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lifetime

Patch Set: IDBDatabase weakptr introduced on IDBObserver Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.h ('K') | « third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.cpp ('k') | third_party/WebKit/Source/modules/indexeddb/IDBObserverChangesRecord.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://github.com/WICG/indexed-db-observers/blob/gh-pages/EXPLAINER.md#chang es-argument	5 // https://github.com/WICG/indexed-db-observers/blob/gh-pages/EXPLAINER.md#chang es-argument

6	6

7 [	7 [

8 Exposed=(Window, Worker),	8 Exposed=(Window, Worker),

9 RuntimeEnabled=IDBObserver	9 RuntimeEnabled=IDBObserver

10 ] interface IDBObserverChanges {	10 ] interface IDBObserverChanges {

11 readonly attribute IDBDatabase database;	11 readonly attribute IDBDatabase database;

12 // Transaction contains the same object stores as the transaction on which I DBTransaction.observe was called.	12 // Transaction contains the same object stores as the transaction on which I DBTransaction.observe was called.

13 readonly attribute IDBTransaction transaction;	13 readonly attribute IDBTransaction transaction;

14 // This is the javascript Map<String, sequence<IDBObserverChangesRecord>>,	14 // This is the javascript Map<String, sequence<IDBObserverChangesRecord>>,

15 // where the key is the object store name.	15 // where the key is the object store name.

16 // TODO(palakj) : Replace 'any' with maplike<DOMString, sequence<IDBObserver ChangesRecord>>.	16 // TODO(palakj) : Replace sequence<IDBObservation> with maplike<DOMString, s equence<IDBObserverChangesRecord>>.

17 [CallWith=ScriptState] readonly attribute any records;	17 [CallWith=ScriptState] readonly attribute sequence<IDBObservation> records;
	Marijn Kruisselbrink 2016/07/11 23:10:40 (maybe not relevant if you're somehow changing thi (maybe not relevant if you're somehow changing this to a map anyway, but:) This should definitely not be sequence<IDBObservation>. sequence should never be used for interface attributes in IDL (see the note at https://heycam.github.io/webidl/#idl-sequence). If you want to return an array FrozenArray might be what you want instead. palakj1 2016/07/13 00:43:51 Changed this to 'any'. Show quoted text On 2016/07/11 at 23:10:40, Marijn Kruisselbrink wrote: > (maybe not relevant if you're somehow changing this to a map anyway, but:) This should definitely not be sequence<IDBObservation>. sequence should never be used for interface attributes in IDL (see the note at https://heycam.github.io/webidl/#idl-sequence). If you want to return an array FrozenArray might be what you want instead. Changed this to 'any'.
18 };	18 };

19	19

20	20

OLD	NEW