Chromium Code Reviews| Index: third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.h |
| diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.h b/third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.h |
| index c93d66d7d5b3d32f7cc40acf222f9e484800ad0e..0a05e6372ccc1250fc8d7bb24e3ef2effba712ae 100644 |
| --- a/third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.h |
| +++ b/third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.h |
| @@ -8,6 +8,7 @@ |
| #include "bindings/core/v8/ScriptValue.h" |
| #include "bindings/core/v8/ScriptWrappable.h" |
| #include "modules/indexeddb/IDBDatabase.h" |
| +#include "modules/indexeddb/IDBObservation.h" |
| #include "modules/indexeddb/IDBTransaction.h" |
| #include "platform/heap/Handle.h" |
| @@ -20,7 +21,12 @@ class IDBObserverChanges final : public GarbageCollected<IDBObserverChanges>, pu |
| DEFINE_WRAPPERTYPEINFO(); |
| public: |
| - static IDBObserverChanges* create(IDBDatabase*, IDBTransaction*, IDBAny* records); |
| + // TODO(palakj): Make this a map objectStoreName -> List<IDBObserverChanges>. |
| + typedef HeapVector<Member<IDBObservation>> ObjectStoreChangesMap; |
| + |
| + // TODO(palakj): Add IDBDatabase* to create. |
|
Marijn Kruisselbrink
2016/07/11 23:10:40
You seemed to have resolved this TODO already?
palakj1
2016/07/13 00:43:51
removed.
|
| + static IDBObserverChanges* create(IDBDatabase*, const std::vector<WebIDBObservation>&, const std::vector<int32_t>& observationIndex); |
| + IDBObserverChanges(IDBDatabase*, const std::vector<WebIDBObservation>&, const std::vector<int32_t>& observationIndex); |
| DECLARE_TRACE(); |
| @@ -30,12 +36,11 @@ public: |
| ScriptValue records(ScriptState*); |
| private: |
| - IDBObserverChanges(IDBDatabase*, IDBTransaction*, IDBAny* records); |
| + void createMap(const std::vector<WebIDBObservation>& observations, const std::vector<int32_t>& observationIndex); |
| Member<IDBDatabase> m_database; |
| Member<IDBTransaction> m_transaction; |
| - // TODO(palakj) : change to appropriate type Map<String, sequence<IDBObserverChangesRecord>>. |
| - Member<IDBAny> m_records; |
| + ObjectStoreChangesMap m_records; |
| }; |
| } // namespace blink |