Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: chrome/browser/android/banners/app_banner_data_fetcher_android.cc

Issue 2124703003: Do not show "Add to Home Screen" info bar if WebAPK is installed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_data_fetcher_android.cc
diff --git a/chrome/browser/android/banners/app_banner_data_fetcher_android.cc b/chrome/browser/android/banners/app_banner_data_fetcher_android.cc
index 10164088aa5ddfb2cfc92468681e243ffb5e2a2e..43f378915144b035e6b6ef2dfafe1ff978b0b6f9 100644
--- a/chrome/browser/android/banners/app_banner_data_fetcher_android.cc
+++ b/chrome/browser/android/banners/app_banner_data_fetcher_android.cc
@@ -73,6 +73,12 @@ base::Closure AppBannerDataFetcherAndroid::FetchWebappSplashScreenImageCallback(
minimum_splash_image_size_in_dp_, webapp_id);
}
+bool AppBannerDataFetcherAndroid::IsWebAppInstalled(
+ content::BrowserContext* browser_context,
+ const GURL& start_url) {
dominickn 2016/07/07 00:50:58 You should explicitly document here that this meth
pkotwicz 2016/07/07 18:12:44 I have added some comments. Let me know if my comm
+ return ShortcutHelper::IsWebApkInstalled(start_url);
+}
+
void AppBannerDataFetcherAndroid::ShowBanner(const GURL& icon_url,
const SkBitmap* icon,
const base::string16& title,

Powered by Google App Engine
This is Rietveld 408576698