Do not show "Add to Home Screen" info bar if WebAPK is installed

chrome/browser/android/banners/app_banner_data_fetcher_android.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/banners/app_banner_data_fetcher_android.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 55 matching lines @@
 
   GURL image_url = ManifestIconSelector::FindBestMatchingIcon(
       manifest().icons, ideal_splash_image_size_in_dp_,
       minimum_splash_image_size_in_dp_);
 
   return base::Bind(&ShortcutHelper::FetchSplashScreenImage,
       web_contents, image_url, ideal_splash_image_size_in_dp_,
       minimum_splash_image_size_in_dp_, webapp_id);
 }
 
+bool AppBannerDataFetcherAndroid::IsWebAppInstalled(
+    content::BrowserContext* browser_context,
+    const GURL& start_url) {

[dominickn, 2016/07/07 00:50:58]

You should explicitly document here that this method will return false if
WebAPKs are not enabled, and return false if a web app is installed, but not as
a WebAPK.

[pkotwicz, 2016/07/07 18:12:44]

I have added some comments. Let me know if my comments can be improved.

+  return ShortcutHelper::IsWebApkInstalled(start_url);
+}
+
 void AppBannerDataFetcherAndroid::ShowBanner(const GURL& icon_url,
                                              const SkBitmap* icon,
                                              const base::string16& title,
                                              const std::string& referrer) {
   content::WebContents* web_contents = GetWebContents();
   DCHECK(web_contents);
 
   infobars::InfoBar* infobar = nullptr;
   if (native_app_data_.is_null()) {
     std::unique_ptr<AppBannerInfoBarDelegateAndroid> delegate(
@@ skipping 17 matching lines @@
     if (infobar) {
       RecordDidShowBanner("AppBanner.NativeApp.Shown");
       TrackDisplayEvent(DISPLAY_EVENT_NATIVE_APP_BANNER_CREATED);
     }
   }
   InfoBarService::FromWebContents(web_contents)
       ->AddInfoBar(base::WrapUnique(infobar));
 }
 
 }  // namespace banners