Do not show "Add to Home Screen" info bar if WebAPK is installed

chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java

Index: chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
index eccfd16e4b410642453111e2b3bd04aaf9196db3..c5af16b7e075e208b6e50bdcc088ba6b3c6d5030 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
@@ -45,6 +45,7 @@ import org.chromium.chrome.browser.widget.RoundedIconGenerator;
 import org.chromium.content_public.common.ScreenOrientationConstants;
 import org.chromium.net.GURLUtils;
 import org.chromium.ui.widget.Toast;
+import org.chromium.webapk.lib.client.WebApkValidator;
 
 import java.io.ByteArrayOutputStream;
 import java.util.List;
@@ -432,6 +433,18 @@ public class ShortcutHelper {
     }
 
     /**
+     * Returns whether there is a WebAPK installed which can handle {@link url}.
+     */
+    @CalledByNative
+    public static boolean isWebApkInstalled(String url) {

[dominickn, 2016/07/07 00:50:58]

Why is this a different check to the one in WebappRegistry? Shouldn't we ideally
have one way to tell if a WebAPK is installed?

[pkotwicz, 2016/07/07 18:12:43]

ShortcutHelper#isWebApkInstalled() is different than
WebappRegistry#isWebApkInstalled() because:

ShortcutHelper#isWebApkInstalled() checks whether a WebAPK is installed given a
URL
WebappRegistry#isWebApkInstalled() checks whether a WebAPK is installed given an
Android package name.

The logic for checking whether a WebAPK is installed in
ShortcutHelper#isWebApkInstalled() is pretty standard. Its the same logic as in
WebappLauncherActivity#isValidWebApk()

[dominickn, 2016/07/08 01:34:37]

Thanks for the explanation.

+        if (!CommandLine.getInstance().hasSwitch(ChromeSwitches.ENABLE_WEBAPK)) {
+            return false;
+        }
+        return WebApkValidator.queryWebApkPackage(ContextUtils.getApplicationContext(), url)
+                != null;
+    }
+
+    /**
      * Compresses a bitmap into a PNG and converts into a Base64 encoded string.
      * The encoded string can be decoded using {@link decodeBitmapFromString(String)}.
      * @param bitmap The Bitmap to compress and encode.