Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2124533002: Revert middle click related changes (Closed)

Created:
4 years, 5 months ago by dtapuska
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Revert middle click related changes This is the CL to revert the related middle button click changes. We decided to revert those changes because the issues that were caused by suppressing click event for middle button was hard to fix without having that event. Particularly the ability to prevent opening a new tab which can be done by "preventDefault"ing the click event of middle button was removed as the result of the original change. For now we revert these changes and we pursue the line of adding a new event for non-primary button click to be able to fix these problem in a more clean way. Revert "Prevent sending click event for non primary button" This reverts commit 76fea00a18f75886ea649414393228180306e13d. Revert "Dispatch middle click manually by tracking mouse" This reverts commit 88eb1110baafcba070e750866a343e81b6bcc524. Revert "Fix history page middle click action" This reverts commit a154aed1a3813cf28c6f477579ed7974a2528570. BUG=255, 618593, 617444, 611019, 617875 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2107093003 Cr-Commit-Position: refs/heads/master@{#403496} (cherry picked from commit 4d9d9183fe8c1a4dbfac9f4a6ef8a337b05c1a40) Committed: https://chromium.googlesource.com/chromium/src/+/eaaefc24ebb90ea1586f1ce7aee411da3da9d16e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -50 lines) Patch
M chrome/browser/resources/history/history.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/ntp4/new_tab.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/resources/synthetic_middleclick.js View 1 chunk +0 lines, -29 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/mouse-click-events-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/script-tests/mouse-click-events.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/MouseEvent.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 chunk +2 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dtapuska
4 years, 5 months ago (2016-07-04 14:46:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eaaefc24ebb90ea1586f1ce7aee411da3da9d16e.

Powered by Google App Engine
This is Rietveld 408576698