Revert middle click related changes

Revert middle click related changes

This is the CL to revert the related middle button click changes. We
decided to revert those changes because the issues that were caused by
suppressing click event for middle button was hard to fix without having
that event. Particularly the ability to prevent opening a new tab which
can be done by "preventDefault"ing the click event of middle button was
removed as the result of the original change. For now we revert these
changes and we pursue the line of adding a new event for non-primary
button click to be able to fix these problem in a more clean way.

Revert "Prevent sending click event for non primary button"

This reverts commit 76fea00a18f75886ea649414393228180306e13d.

Revert "Dispatch middle click manually by tracking mouse"

This reverts commit 88eb1110baafcba070e750866a343e81b6bcc524.

Revert "Fix history page middle click action"

This reverts commit a154aed1a3813cf28c6f477579ed7974a2528570.

BUG=255, 618593, 617444, 611019, 617875
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4d9d9183fe8c1a4dbfac9f4a6ef8a337b05c1a40
Cr-Commit-Position: refs/heads/master@{#403496}

[Navid Zolghadr, 2016-06-29 15:24:15]

Description was changed from

==========
Revert "Prevent sending click event for non primary button"

This reverts commit 76fea00a18f75886ea649414393228180306e13d.

Revert "Dispatch middle click manually by tracking mouse"

This reverts commit 88eb1110baafcba070e750866a343e81b6bcc524.

Revert "Fix history page middle click action"

This reverts commit a154aed1a3813cf28c6f477579ed7974a2528570.

BUG=255,618593,617444,611019,617875
==========

to

==========
Revert "Prevent sending click event for non primary button"

This reverts commit 76fea00a18f75886ea649414393228180306e13d.

Revert "Dispatch middle click manually by tracking mouse"

This reverts commit 88eb1110baafcba070e750866a343e81b6bcc524.

Revert "Fix history page middle click action"

This reverts commit a154aed1a3813cf28c6f477579ed7974a2528570.

BUG=255,618593,617444,611019,617875
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Navid Zolghadr, 2016-06-29 15:28:19]

Description was changed from

==========
Revert "Prevent sending click event for non primary button"

This reverts commit 76fea00a18f75886ea649414393228180306e13d.

Revert "Dispatch middle click manually by tracking mouse"

This reverts commit 88eb1110baafcba070e750866a343e81b6bcc524.

Revert "Fix history page middle click action"

This reverts commit a154aed1a3813cf28c6f477579ed7974a2528570.

BUG=255,618593,617444,611019,617875
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Revert "Prevent sending click event for non primary button"

This reverts commit 76fea00a18f75886ea649414393228180306e13d.

Revert "Dispatch middle click manually by tracking mouse"

This reverts commit 88eb1110baafcba070e750866a343e81b6bcc524.

Revert "Fix history page middle click action"

This reverts commit a154aed1a3813cf28c6f477579ed7974a2528570.

BUG=255,618593,617444,611019,617875
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Navid Zolghadr, 2016-06-29 15:28:19]

nzolghadr@chromium.org changed reviewers:
+ dtapuska@chromium.org, mustaq@chromium.org, rbyers@chromium.org

[Navid Zolghadr, 2016-06-29 15:35:31]

nzolghadr@chromium.org changed reviewers:
+ dbeam@chromium.org, thestig@chromium.org

[Navid Zolghadr, 2016-06-29 15:35:31]

dbeam@chromium.org: Please review changes in 

chrome/browser/resources/history/history.js
chrome/browser/resources/ntp4/new_tab.html


thestig@chromium.org: Please review changes in 

chrome/browser/ui/browser_browsertest.cc

[dtapuska, 2016-06-29 15:38:48]

On 2016/06/29 15:35:31, Navid Zolghadr wrote:
> mailto:dbeam@chromium.org: Please review changes in 
> 
> chrome/browser/resources/history/history.js
> chrome/browser/resources/ntp4/new_tab.html
> 
> 
> mailto:thestig@chromium.org: Please review changes in 
> 
> chrome/browser/ui/browser_browsertest.cc

lgtm. Can we change the commit message so we indicate why we are reverting it at
this time?

[Rick Byers, 2016-06-29 15:39:55]

On 2016/06/29 15:38:48, dtapuska wrote:
> On 2016/06/29 15:35:31, Navid Zolghadr wrote:
> > mailto:dbeam@chromium.org: Please review changes in 
> > 
> > chrome/browser/resources/history/history.js
> > chrome/browser/resources/ntp4/new_tab.html
> > 
> > 
> > mailto:thestig@chromium.org: Please review changes in 
> > 
> > chrome/browser/ui/browser_browsertest.cc
> 
> lgtm. Can we change the commit message so we indicate why we are reverting it
at
> this time?

Rather than revert all the changes, would it be simpler / more convenient to put
them behind a RuntimeEnabledFeature with status=experimental?

[Navid Zolghadr, 2016-06-29 15:43:26]

Description was changed from

==========
Revert "Prevent sending click event for non primary button"

This reverts commit 76fea00a18f75886ea649414393228180306e13d.

Revert "Dispatch middle click manually by tracking mouse"

This reverts commit 88eb1110baafcba070e750866a343e81b6bcc524.

Revert "Fix history page middle click action"

This reverts commit a154aed1a3813cf28c6f477579ed7974a2528570.

BUG=255,618593,617444,611019,617875
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
This is the CL to revert the related middle button click changes. We decided to
revert those changes because the issues that were caused by suppressing click
event for middle button was hard to fix without having that event. Particularly
the ability to prevent opening a new tab which can be done by
"preventDefault"ing the click event of middle button was removed as the result
of the original change. For now we revert these changes and we pursue the line
of adding a new event for non-primary button click to be able to fix these
problem in a more clean way.

Revert "Prevent sending click event for non primary button"

This reverts commit 76fea00a18f75886ea649414393228180306e13d.

Revert "Dispatch middle click manually by tracking mouse"

This reverts commit 88eb1110baafcba070e750866a343e81b6bcc524.

Revert "Fix history page middle click action"

This reverts commit a154aed1a3813cf28c6f477579ed7974a2528570.

BUG=255,618593,617444,611019,617875
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Navid Zolghadr, 2016-06-29 15:55:47]

On 2016/06/29 15:39:55, Rick Byers wrote:
> On 2016/06/29 15:38:48, dtapuska wrote:
> > On 2016/06/29 15:35:31, Navid Zolghadr wrote:
> > > mailto:dbeam@chromium.org: Please review changes in 
> > > 
> > > chrome/browser/resources/history/history.js
> > > chrome/browser/resources/ntp4/new_tab.html
> > > 
> > > 
> > > mailto:thestig@chromium.org: Please review changes in 
> > > 
> > > chrome/browser/ui/browser_browsertest.cc
> > 
> > lgtm. Can we change the commit message so we indicate why we are reverting
it
> at
> > this time?
> 
> Rather than revert all the changes, would it be simpler / more convenient to
put
> them behind a RuntimeEnabledFeature with status=experimental?

I guess it depends on how serious is some of those issues that are mentioned in
the description and whether it is okay to have them broken behind the
experimental flag.
Also when we introduce the non-primary button click I'm going to remove the
synthetic event generation anyway. So I might as well remove it for now and just
add the non-primary button click event and handling it directly.
Also I'm not sure how to generate the synthetic click event based on that
experimental flag in the js file.
So having these in mind do you still think making this change experimental
better than reverting it?

[Rick Byers, 2016-06-29 16:05:30]

On 2016/06/29 15:55:47, Navid Zolghadr wrote:
> On 2016/06/29 15:39:55, Rick Byers wrote:
> > On 2016/06/29 15:38:48, dtapuska wrote:
> > > On 2016/06/29 15:35:31, Navid Zolghadr wrote:
> > > > mailto:dbeam@chromium.org: Please review changes in 
> > > > 
> > > > chrome/browser/resources/history/history.js
> > > > chrome/browser/resources/ntp4/new_tab.html
> > > > 
> > > > 
> > > > mailto:thestig@chromium.org: Please review changes in 
> > > > 
> > > > chrome/browser/ui/browser_browsertest.cc
> > > 
> > > lgtm. Can we change the commit message so we indicate why we are reverting
> it
> > at
> > > this time?
> > 
> > Rather than revert all the changes, would it be simpler / more convenient to
> put
> > them behind a RuntimeEnabledFeature with status=experimental?
> 
> I guess it depends on how serious is some of those issues that are mentioned
in
> the description and whether it is okay to have them broken behind the
> experimental flag.

If there are some substantial known breakage then yeah, "experimental" is
probably not appropriate yet.  You can of course use "status=test" though.

> Also when we introduce the non-primary button click I'm going to remove the
> synthetic event generation anyway. So I might as well remove it for now and
just
> add the non-primary button click event and handling it directly.

> Also I'm not sure how to generate the synthetic click event based on that
> experimental flag in the js file.

Yeah, good point - you really do want that feature available before you change
the WebUI.  There's probably no case now where you want the synthetic event
generation in the WebUI.  Once we have the altclick event "experimental" then
you'll probably want to feature-detect for that in the WebUI and use it instead
of 'click'.

> So having these in mind do you still think making this change experimental
> better than reverting it?

I agree it probably can't be experimental yet.  It's up to you if you'd rather
revert or use a status=test feature - either is OK with me.  Generally when we
have a web exposed feature we can't enable yet, we rely on the various status of
RuntimeEnabledFeatures rather than landing/reverting/re-landing.

[Navid Zolghadr, 2016-06-29 20:31:08]

On 2016/06/29 16:05:30, Rick Byers wrote:
> On 2016/06/29 15:55:47, Navid Zolghadr wrote:
> > On 2016/06/29 15:39:55, Rick Byers wrote:
> > > On 2016/06/29 15:38:48, dtapuska wrote:
> > > > On 2016/06/29 15:35:31, Navid Zolghadr wrote:
> > > > > mailto:dbeam@chromium.org: Please review changes in 
> > > > > 
> > > > > chrome/browser/resources/history/history.js
> > > > > chrome/browser/resources/ntp4/new_tab.html
> > > > > 
> > > > > 
> > > > > mailto:thestig@chromium.org: Please review changes in 
> > > > > 
> > > > > chrome/browser/ui/browser_browsertest.cc
> > > > 
> > > > lgtm. Can we change the commit message so we indicate why we are
reverting
> > it
> > > at
> > > > this time?
> > > 
> > > Rather than revert all the changes, would it be simpler / more convenient
to
> > put
> > > them behind a RuntimeEnabledFeature with status=experimental?
> > 
> > I guess it depends on how serious is some of those issues that are mentioned
> in
> > the description and whether it is okay to have them broken behind the
> > experimental flag.
> 
> If there are some substantial known breakage then yeah, "experimental" is
> probably not appropriate yet.  You can of course use "status=test" though.
> 
> > Also when we introduce the non-primary button click I'm going to remove the
> > synthetic event generation anyway. So I might as well remove it for now and
> just
> > add the non-primary button click event and handling it directly.
> 
> > Also I'm not sure how to generate the synthetic click event based on that
> > experimental flag in the js file.
> 
> Yeah, good point - you really do want that feature available before you change
> the WebUI.  There's probably no case now where you want the synthetic event
> generation in the WebUI.  Once we have the altclick event "experimental" then
> you'll probably want to feature-detect for that in the WebUI and use it
instead
> of 'click'.
> 
> > So having these in mind do you still think making this change experimental
> > better than reverting it?
> 
> I agree it probably can't be experimental yet.  It's up to you if you'd rather
> revert or use a status=test feature - either is OK with me.  Generally when we
> have a web exposed feature we can't enable yet, we rely on the various status
of
> RuntimeEnabledFeatures rather than landing/reverting/re-landing.

So let's go with reverting the change (which is this CL as is) for now if you
are okay with that as well.

[Dan Beam, 2016-06-29 22:41:26]

lgtm

[Rick Byers, 2016-06-29 22:45:39]

Ok LGTM

[Lei Zhang, 2016-06-29 22:53:45]

Description was changed from

==========
This is the CL to revert the related middle button click changes. We decided to
revert those changes because the issues that were caused by suppressing click
event for middle button was hard to fix without having that event. Particularly
the ability to prevent opening a new tab which can be done by
"preventDefault"ing the click event of middle button was removed as the result
of the original change. For now we revert these changes and we pursue the line
of adding a new event for non-primary button click to be able to fix these
problem in a more clean way.

Revert "Prevent sending click event for non primary button"

This reverts commit 76fea00a18f75886ea649414393228180306e13d.

Revert "Dispatch middle click manually by tracking mouse"

This reverts commit 88eb1110baafcba070e750866a343e81b6bcc524.

Revert "Fix history page middle click action"

This reverts commit a154aed1a3813cf28c6f477579ed7974a2528570.

BUG=255,618593,617444,611019,617875
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Revert middle click related changes

This is the CL to revert the related middle button click changes. We
decided to revert those changes because the issues that were caused by
suppressing click event for middle button was hard to fix without having
that event. Particularly the ability to prevent opening a new tab which
can be done by "preventDefault"ing the click event of middle button was
removed as the result of the original change. For now we revert these
changes and we pursue the line of adding a new event for non-primary
button click to be able to fix these problem in a more clean way.

Revert "Prevent sending click event for non primary button"

This reverts commit 76fea00a18f75886ea649414393228180306e13d.

Revert "Dispatch middle click manually by tracking mouse"

This reverts commit 88eb1110baafcba070e750866a343e81b6bcc524.

Revert "Fix history page middle click action"

This reverts commit a154aed1a3813cf28c6f477579ed7974a2528570.

BUG=255,618593,617444,611019,617875
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Lei Zhang, 2016-06-29 22:54:17]

rs lgtm, though I rewrote the commit message so it fits in 72 columns.

[Navid Zolghadr, 2016-06-29 22:58:25]

The CQ bit was checked by nzolghadr@chromium.org

[commit-bot: I haz the power, 2016-06-29 22:59:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 02:37:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 02:37:39]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Navid Zolghadr, 2016-06-30 02:40:49]

The CQ bit was checked by nzolghadr@chromium.org

[commit-bot: I haz the power, 2016-06-30 02:41:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 04:42:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 04:42:07]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Navid Zolghadr, 2016-06-30 11:52:15]

The CQ bit was checked by nzolghadr@chromium.org

[commit-bot: I haz the power, 2016-06-30 11:52:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 13:04:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 13:04:31]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Navid Zolghadr, 2016-06-30 16:29:22]

The CQ bit was checked by nzolghadr@chromium.org

[commit-bot: I haz the power, 2016-06-30 16:29:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 18:53:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 18:53:02]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Dan Beam, 2016-07-01 04:27:49]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-07-01 04:28:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 05:51:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-01 05:51:34]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Navid Zolghadr, 2016-07-01 14:00:20]

The CQ bit was checked by nzolghadr@chromium.org

[commit-bot: I haz the power, 2016-07-01 14:00:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 17:32:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-01 17:32:04]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Navid Zolghadr, 2016-07-01 17:48:03]

The CQ bit was checked by nzolghadr@chromium.org

[commit-bot: I haz the power, 2016-07-01 17:48:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Rick Byers, 2016-07-01 18:31:17]

On 2016/07/01 17:32:04, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

Ugh, have all of these failures really been unrelated flakiness?  I spotted
checked a couple and it looked like it to me.  That's unusually terrible!  Have
you looked to see if bugs exist for any of the flakiness hit here?  I'd be happy
to try to bump the priority on the underlying issues, this is ridiculous...

[Navid Zolghadr, 2016-07-01 18:43:02]

On 2016/07/01 18:31:17, Rick Byers wrote:
> On 2016/07/01 17:32:04, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
> 
> Ugh, have all of these failures really been unrelated flakiness?  I spotted
> checked a couple and it looked like it to me.  That's unusually terrible! 
Have
> you looked to see if bugs exist for any of the flakiness hit here?  I'd be
happy
> to try to bump the priority on the underlying issues, this is ridiculous...

The frustrating point is that it did pass once while I triggered the bot myself
but every time I add it to CQ it fails! It seems that this time it goes through
though. Either those tests are fixed or this was the lucky time as
win_chromium_rel_ng passed already. If this time failed I look at it more deeply
to find existing bugs or related stuff.

[commit-bot: I haz the power, 2016-07-01 19:03:11]

Description was changed from

==========
Revert middle click related changes

This is the CL to revert the related middle button click changes. We
decided to revert those changes because the issues that were caused by
suppressing click event for middle button was hard to fix without having
that event. Particularly the ability to prevent opening a new tab which
can be done by "preventDefault"ing the click event of middle button was
removed as the result of the original change. For now we revert these
changes and we pursue the line of adding a new event for non-primary
button click to be able to fix these problem in a more clean way.

Revert "Prevent sending click event for non primary button"

This reverts commit 76fea00a18f75886ea649414393228180306e13d.

Revert "Dispatch middle click manually by tracking mouse"

This reverts commit 88eb1110baafcba070e750866a343e81b6bcc524.

Revert "Fix history page middle click action"

This reverts commit a154aed1a3813cf28c6f477579ed7974a2528570.

BUG=255,618593,617444,611019,617875
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Revert middle click related changes

This is the CL to revert the related middle button click changes. We
decided to revert those changes because the issues that were caused by
suppressing click event for middle button was hard to fix without having
that event. Particularly the ability to prevent opening a new tab which
can be done by "preventDefault"ing the click event of middle button was
removed as the result of the original change. For now we revert these
changes and we pursue the line of adding a new event for non-primary
button click to be able to fix these problem in a more clean way.

Revert "Prevent sending click event for non primary button"

This reverts commit 76fea00a18f75886ea649414393228180306e13d.

Revert "Dispatch middle click manually by tracking mouse"

This reverts commit 88eb1110baafcba070e750866a343e81b6bcc524.

Revert "Fix history page middle click action"

This reverts commit a154aed1a3813cf28c6f477579ed7974a2528570.

BUG=255,618593,617444,611019,617875
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-07-01 19:03:13]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-01 19:03:31]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-01 19:05:03]

Description was changed from

==========
Revert middle click related changes

This is the CL to revert the related middle button click changes. We
decided to revert those changes because the issues that were caused by
suppressing click event for middle button was hard to fix without having
that event. Particularly the ability to prevent opening a new tab which
can be done by "preventDefault"ing the click event of middle button was
removed as the result of the original change. For now we revert these
changes and we pursue the line of adding a new event for non-primary
button click to be able to fix these problem in a more clean way.

Revert "Prevent sending click event for non primary button"

This reverts commit 76fea00a18f75886ea649414393228180306e13d.

Revert "Dispatch middle click manually by tracking mouse"

This reverts commit 88eb1110baafcba070e750866a343e81b6bcc524.

Revert "Fix history page middle click action"

This reverts commit a154aed1a3813cf28c6f477579ed7974a2528570.

BUG=255,618593,617444,611019,617875
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Revert middle click related changes

This is the CL to revert the related middle button click changes. We
decided to revert those changes because the issues that were caused by
suppressing click event for middle button was hard to fix without having
that event. Particularly the ability to prevent opening a new tab which
can be done by "preventDefault"ing the click event of middle button was
removed as the result of the original change. For now we revert these
changes and we pursue the line of adding a new event for non-primary
button click to be able to fix these problem in a more clean way.

Revert "Prevent sending click event for non primary button"

This reverts commit 76fea00a18f75886ea649414393228180306e13d.

Revert "Dispatch middle click manually by tracking mouse"

This reverts commit 88eb1110baafcba070e750866a343e81b6bcc524.

Revert "Fix history page middle click action"

This reverts commit a154aed1a3813cf28c6f477579ed7974a2528570.

BUG=255,618593,617444,611019,617875
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4d9d9183fe8c1a4dbfac9f4a6ef8a337b05c1a40
Cr-Commit-Position: refs/heads/master@{#403496}
==========

[commit-bot: I haz the power, 2016-07-01 19:05:05]

Patchset 1 (id:??) landed as
https://crrev.com/4d9d9183fe8c1a4dbfac9f4a6ef8a337b05c1a40
Cr-Commit-Position: refs/heads/master@{#403496}