Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3191)

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 2124533002: Revert middle click related changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_browsertest.cc
diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc
index 89237794d0d0f55784e1a51729c8bc9eb97e6210..93545b81969b47e0805a3c1859898c05709f2fd5 100644
--- a/chrome/browser/ui/browser_browsertest.cc
+++ b/chrome/browser/ui/browser_browsertest.cc
@@ -2589,6 +2589,28 @@ IN_PROC_BROWSER_TEST_F(ClickModifierTest, WindowOpenControlShiftClickTest) {
RunTest(browser(), GetWindowOpenURL(), modifiers, button, disposition);
}
+// Middle-clicks open in a background tab.
+#if defined(OS_LINUX)
+// http://crbug.com/396347
+#define MAYBE_WindowOpenMiddleClickTest DISABLED_WindowOpenMiddleClickTest
+#else
+#define MAYBE_WindowOpenMiddleClickTest WindowOpenMiddleClickTest
+#endif
+IN_PROC_BROWSER_TEST_F(ClickModifierTest, MAYBE_WindowOpenMiddleClickTest) {
+ int modifiers = 0;
+ blink::WebMouseEvent::Button button = blink::WebMouseEvent::ButtonMiddle;
+ WindowOpenDisposition disposition = NEW_BACKGROUND_TAB;
+ RunTest(browser(), GetWindowOpenURL(), modifiers, button, disposition);
+}
+
+// Shift-middle-clicks open in a foreground tab.
+IN_PROC_BROWSER_TEST_F(ClickModifierTest, WindowOpenShiftMiddleClickTest) {
+ int modifiers = blink::WebInputEvent::ShiftKey;
+ blink::WebMouseEvent::Button button = blink::WebMouseEvent::ButtonMiddle;
+ WindowOpenDisposition disposition = NEW_FOREGROUND_TAB;
+ RunTest(browser(), GetWindowOpenURL(), modifiers, button, disposition);
+}
+
// Tests for clicking on normal links.
IN_PROC_BROWSER_TEST_F(ClickModifierTest, HrefBasicClickTest) {

Powered by Google App Engine
This is Rietveld 408576698