Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2124183002: Rename a gpu workaround. (Closed)

Created:
4 years, 5 months ago by erikchen
Modified:
4 years, 5 months ago
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, piman+watch_chromium.org, Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@temp16_offscreen_gmb_bug
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename a gpu workaround. Rename disable_webgl_multisampling_color_mask_usage to disable_multisampling_color_mask_usage, as the command buffer also needs it for native GpuMemoryBuffer back buffers. No intended behavior change. BUG=602484 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/45d8c8bc3da648c423f4bc009f6b6cdcaebd18f7 Cr-Commit-Position: refs/heads/master@{#404181}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M gpu/command_buffer/common/capabilities.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/common/capabilities.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/ipc/common/gpu_command_buffer_traits_multi.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 23 (10 generated)
erikchen
piman: Please review.
4 years, 5 months ago (2016-07-06 23:52:58 UTC) #3
piman
lgtm
4 years, 5 months ago (2016-07-07 00:15:01 UTC) #4
erikchen
kbr: Please review third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp. dcheng: Please review gpu/ipc/common/gpu_command_buffer_traits_multi.h
4 years, 5 months ago (2016-07-07 00:28:06 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124183002/1
4 years, 5 months ago (2016-07-07 00:28:52 UTC) #8
dcheng
rs lgtm
4 years, 5 months ago (2016-07-07 00:51:18 UTC) #9
Ken Russell (switch to Gerrit)
lgtm
4 years, 5 months ago (2016-07-07 02:47:45 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-07 05:43:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124183002/1
4 years, 5 months ago (2016-07-07 15:29:56 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years, 5 months ago (2016-07-07 17:34:11 UTC) #17
Ken Russell (switch to Gerrit)
On 2016/07/07 17:34:11, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 5 months ago (2016-07-07 17:46:32 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124183002/1
4 years, 5 months ago (2016-07-07 17:47:23 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 18:20:29 UTC) #21
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 18:22:30 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45d8c8bc3da648c423f4bc009f6b6cdcaebd18f7
Cr-Commit-Position: refs/heads/master@{#404181}

Powered by Google App Engine
This is Rietveld 408576698