Fix a bug with emulated RGB offscreen native GpuMemoryBuffers.

Fix a bug with emulated RGB offscreen native GpuMemoryBuffers.

Some command buffers backed by a surface need to have the back buffer cleared.
This logic doesn't apply correctly to emulated RGB offscreen backbuffers.
There's no need to do the clear to begin with for offscreen buffers since the
offscreen buffer is cleared by ResizeOffscreenFrameBuffer.

BUG=602484
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/8ce92bf1f6eb02e80d516e02ef23842dafc9a0aa
Cr-Commit-Position: refs/heads/master@{#404017}

[erikchen, 2016-07-06 22:44:15]

Description was changed from

==========
Fix a bug with emulated RGB offscreen native GpuMemoryBuffers.

Some command buffers backed by a surface need to have the back buffer cleared.
This logic doesn't apply correctly to emulated RGB offscreen backbuffers.
There's no need to do the clear to begin with for offscreen buffers since the
offscreen buffer is cleared by ResizeOffscreenFrameBuffer.

BUG=602484
==========

to

==========
Fix a bug with emulated RGB offscreen native GpuMemoryBuffers.

Some command buffers backed by a surface need to have the back buffer cleared.
This logic doesn't apply correctly to emulated RGB offscreen backbuffers.
There's no need to do the clear to begin with for offscreen buffers since the
offscreen buffer is cleared by ResizeOffscreenFrameBuffer.

BUG=602484
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[erikchen, 2016-07-06 22:44:44]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[erikchen, 2016-07-06 22:45:01]

erikchen@chromium.org changed reviewers:
+ piman@chromium.org

[erikchen, 2016-07-06 22:45:02]

piman: Please review.

The updated unit test fails without the new logic, and passes with the new
logic.

[commit-bot: I haz the power, 2016-07-06 22:45:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-07-06 22:57:36]

lgtm

[commit-bot: I haz the power, 2016-07-06 23:46:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 23:46:18]

Dry run: This issue passed the CQ dry run.

[erikchen, 2016-07-07 00:28:33]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-07-07 00:28:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 00:37:05]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-07 00:39:34]

Description was changed from

==========
Fix a bug with emulated RGB offscreen native GpuMemoryBuffers.

Some command buffers backed by a surface need to have the back buffer cleared.
This logic doesn't apply correctly to emulated RGB offscreen backbuffers.
There's no need to do the clear to begin with for offscreen buffers since the
offscreen buffer is cleared by ResizeOffscreenFrameBuffer.

BUG=602484
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix a bug with emulated RGB offscreen native GpuMemoryBuffers.

Some command buffers backed by a surface need to have the back buffer cleared.
This logic doesn't apply correctly to emulated RGB offscreen backbuffers.
There's no need to do the clear to begin with for offscreen buffers since the
offscreen buffer is cleared by ResizeOffscreenFrameBuffer.

BUG=602484
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/8ce92bf1f6eb02e80d516e02ef23842dafc9a0aa
Cr-Commit-Position: refs/heads/master@{#404017}
==========

[commit-bot: I haz the power, 2016-07-07 00:39:35]

Patchset 1 (id:??) landed as
https://crrev.com/8ce92bf1f6eb02e80d516e02ef23842dafc9a0aa
Cr-Commit-Position: refs/heads/master@{#404017}