Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2128753002: Add workaround for multisampling color masks for the command buffer. (Closed)

Created:
4 years, 5 months ago by erikchen
Modified:
4 years, 5 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@temp17_gmb_workaround
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add workaround for multisampling color masks for the command buffer. On old AMD GPUs on macOS, glColorMask doesn't work correctly for multisampled renderbuffers and the alpha channel can be overwritten. This workaround clears the alpha channel before resolving. BUG=602484 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/d4e64fc3153e756b8a1398b8d9dba4f220df6e49 Cr-Commit-Position: refs/heads/master@{#404223}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +20 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (8 generated)
erikchen
piman: Please review. The test GLNativeGMBTest.TestNativeGMBBackbufferWithDifferentConfigurations correctly discerns between the existence (or lack thereof) of ...
4 years, 5 months ago (2016-07-07 00:16:04 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128753002/1
4 years, 5 months ago (2016-07-07 00:16:55 UTC) #5
piman
lgtm
4 years, 5 months ago (2016-07-07 00:19:36 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_tests_rel/builds/1730)
4 years, 5 months ago (2016-07-07 03:07:08 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128753002/1
4 years, 5 months ago (2016-07-07 15:30:22 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) ...
4 years, 5 months ago (2016-07-07 17:34:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128753002/1
4 years, 5 months ago (2016-07-07 19:58:59 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 20:04:59 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 20:05:17 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 20:06:46 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d4e64fc3153e756b8a1398b8d9dba4f220df6e49
Cr-Commit-Position: refs/heads/master@{#404223}

Powered by Google App Engine
This is Rietveld 408576698