PDF: Replace usage of i18nTemplate with Polymer data binding

PDF: Replace usage of i18nTemplate with Polymer data binding

i18n_template.js is deprecated, and is built on top of a deprecated
platform feature. The replacement for it (ReplaceTemplateExpresssions)
is not available for component extensions. This CL replaces all usage of
i18nTemplate in the PDF viewer with Polymer data binding,
which works sufficiently well since there's no complicated l10n in the
PDF viewer.

BUG=621736
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6780c776212ce304bb05dbf60b9ced28a89fb7c8
Cr-Commit-Position: refs/heads/master@{#404796}

[tsergeant, 2016-07-07 05:51:01]

Description was changed from

==========
PDF: Replace usage of i18nTemplate with Polymer data binding

i18n_template.js is deprecated, and is built on top of a deprecated
platform feature. The replacement for it (ReplaceTemplateExpresssions)
is not available for component extensions. This CL replaces all usage of
i18nTemplate in the PDF viewer with Polymer data binding,
which works sufficiently well since there's no complicated l10n in the
PDF viewer.

BUG=621736
==========

to

==========
PDF: Replace usage of i18nTemplate with Polymer data binding

i18n_template.js is deprecated, and is built on top of a deprecated
platform feature. The replacement for it (ReplaceTemplateExpresssions)
is not available for component extensions. This CL replaces all usage of
i18nTemplate in the PDF viewer with Polymer data binding,
which works sufficiently well since there's no complicated l10n in the
PDF viewer.

BUG=621736
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-07-07 05:56:27]

Patchset #1 (id:1) has been deleted

[tsergeant, 2016-07-07 05:56:57]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-07 05:57:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2016-07-07 05:58:45]

tsergeant@chromium.org changed reviewers:
+ raymes@chromium.org

[tsergeant, 2016-07-07 05:58:46]

PTAL

[commit-bot: I haz the power, 2016-07-07 06:30:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 06:30:49]

Dry run: This issue passed the CQ dry run.

[raymes, 2016-07-12 05:21:50]

lgtm

https://codereview.chromium.org/2123983003/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-toolbar.js
(right):

https://codereview.chromium.org/2123983003/diff/20001/chrome/browser/resource...
chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-toolbar.js:30:
* Change button tooltips to match any changes to loadTimeData.
is this comment still accurate?

[tsergeant, 2016-07-12 06:11:39]

https://codereview.chromium.org/2123983003/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-toolbar.js
(right):

https://codereview.chromium.org/2123983003/diff/20001/chrome/browser/resource...
chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-toolbar.js:30:
* Change button tooltips to match any changes to loadTimeData.
On 2016/07/12 05:21:49, raymes wrote:
> is this comment still accurate?

Not quite, I've tweaked it to reflect the changes.

[tsergeant, 2016-07-12 06:12:06]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2016-07-12 06:12:07]

The patchset sent to the CQ was uploaded after l-g-t-m from raymes@chromium.org
Link to the patchset: https://codereview.chromium.org/2123983003/#ps40001
(title: "Tweak comment")

[commit-bot: I haz the power, 2016-07-12 06:12:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 07:47:37]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-07-12 07:49:13]

Description was changed from

==========
PDF: Replace usage of i18nTemplate with Polymer data binding

i18n_template.js is deprecated, and is built on top of a deprecated
platform feature. The replacement for it (ReplaceTemplateExpresssions)
is not available for component extensions. This CL replaces all usage of
i18nTemplate in the PDF viewer with Polymer data binding,
which works sufficiently well since there's no complicated l10n in the
PDF viewer.

BUG=621736
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
PDF: Replace usage of i18nTemplate with Polymer data binding

i18n_template.js is deprecated, and is built on top of a deprecated
platform feature. The replacement for it (ReplaceTemplateExpresssions)
is not available for component extensions. This CL replaces all usage of
i18nTemplate in the PDF viewer with Polymer data binding,
which works sufficiently well since there's no complicated l10n in the
PDF viewer.

BUG=621736
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6780c776212ce304bb05dbf60b9ced28a89fb7c8
Cr-Commit-Position: refs/heads/master@{#404796}
==========

[commit-bot: I haz the power, 2016-07-12 07:49:14]

Patchset 2 (id:??) landed as
https://crrev.com/6780c776212ce304bb05dbf60b9ced28a89fb7c8
Cr-Commit-Position: refs/heads/master@{#404796}

[Dan Beam, 2016-07-12 19:32:46]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-07-12 19:32:46]

yay, another way to do strings in webui!

[chromium-reviews, 2016-07-12 23:35:12]

Yeah =(

I looked into using app-localize-behavior and it pulls in some extra
dependencies and is a bit more complex than what we need for PDF.

On Wed, 13 Jul 2016, 5:32 AM <dbeam@chromium.org> wrote:

> yay, another way to do strings in webui!
>
> https://codereview.chromium.org/2123983003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Dan Beam, 2016-07-13 02:41:36]

On 2016/07/12 23:35:12, chromium-reviews wrote:
> Yeah =(
> 
> I looked into using app-localize-behavior

what about I18nBehavior?

> and it pulls in some extra
> dependencies and is a bit more complex than what we need for PDF.
> 
> On Wed, 13 Jul 2016, 5:32 AM <mailto:dbeam@chromium.org> wrote:
> 
> > yay, another way to do strings in webui!
> >
> > https://codereview.chromium.org/2123983003/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[tsergeant, 2016-07-13 07:31:08]

On 2016/07/13 02:41:36, Dan Beam wrote:
> On 2016/07/12 23:35:12, chromium-reviews wrote:
> > Yeah =(
> > 
> > I looked into using app-localize-behavior
> 
> what about I18nBehavior?

Eugh, I didn't realise that existed >.> . We probably could switch to that, but
I don't think there's any particular need to change.