chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html - Issue 2123983003: PDF: Replace usage of i18nTemplate with Polymer data binding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html

Issue 2123983003: PDF: Replace usage of i18nTemplate with Polymer data binding (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tweak comment Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/pdf/elements/viewer-error-screen/viewer-error-screen.js ('k') | chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html

diff --git a/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html b/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html

index 7016e78c439d2504fb87c8c55bdd8a522a60dfda..bebbd75400ccdb60172cf244d0f0b28493d06bc7 100644

--- a/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html

+++ b/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html

@@ -8,7 +8,7 @@

<paper-input-container id="pageselector" no-label-float>

<input id="input" is="iron-input" value="{{pageNo}}"

prevent-invalid-input allowed-pattern="\d" on-mouseup="select"

- on-change="pageNoCommitted" i18n-values="aria-label:labelPageNumber">

+ on-change="pageNoCommitted" aria-label$="{{strings.labelPageNumber}}">

</paper-input-container>