chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js - Issue 2123983003: PDF: Replace usage of i18nTemplate with Polymer data binding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js

Issue 2123983003: PDF: Replace usage of i18nTemplate with Polymer data binding (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tweak comment Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html ('k') | chrome/browser/resources/pdf/elements/viewer-password-screen/viewer-password-screen.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js

diff --git a/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js b/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js

index 75a83300a9b90a3f44ebc2f18bcc4a1a678fbd4b..ad344f60e138341a7f7ae3f73a870e8ae5076945 100644

--- a/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js

+++ b/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js

@@ -23,7 +23,9 @@ Polymer({

pageNo: {

type: Number,

value: 1

- }

+ },

+ strings: Object,

pageNoCommitted: function() {