Remove duplicated function in RenderView.

Remove duplicated function in RenderView.

TBR=brettw@chromium.org
BUG=none

Committed: https://crrev.com/4fbd3d7485a9f6730be16a5e76c769a2b83961ac
Cr-Commit-Position: refs/heads/master@{#404016}

[wjmaclean, 2016-07-05 20:14:08]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-05 20:14:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 21:41:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-05 21:41:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[wjmaclean, 2016-07-06 15:37:43]

Description was changed from

==========
Remove duplicated function in RenderView.

BUG=none
==========

to

==========
Remove duplicated function in RenderView.

BUG=none
==========

[wjmaclean, 2016-07-06 15:37:43]

wjmaclean@chromium.org changed reviewers:
+ creis@chromium.org

[wjmaclean, 2016-07-06 15:38:34]

Tiny CL.

I would normally have TBR'd this, but would just like to make sure I'm not
missing any reason in favour of having duplication for testing here.

[Charlie Reis, 2016-07-06 17:23:37]

creis@chromium.org changed reviewers:
+ oshima@chromium.org

[Charlie Reis, 2016-07-06 17:23:37]

Thanks for catching this!  Interestingly, both the test and non-test version
were added by oshima@ 2 days apart (Jan 12 and 14):
https://codereview.chromium.org/1571833002
https://codereview.chromium.org/1572703002

oshima@, did you have a reason to have both?  It seems safe to remove
GetDeviceScaleFactorForTest now that we have GetDeviceScaleFactor.

LGTM, anyway.

https://codereview.chromium.org/2123833002/diff/1/content/shell/renderer/layo...
File content/shell/renderer/layout_test/blink_test_runner.cc (right):

https://codereview.chromium.org/2123833002/diff/1/content/shell/renderer/layo...
content/shell/renderer/layout_test/blink_test_runner.cc:712: float
BlinkTestRunner::GetDeviceScaleFactorForTest() const {
We could probably drop the "ForTest" from here as well.

[oshima, 2016-07-06 17:38:58]

On 2016/07/06 17:23:37, Charlie Reis wrote:
> Thanks for catching this!  Interestingly, both the test and non-test version
> were added by oshima@ 2 days apart (Jan 12 and 14):
> https://codereview.chromium.org/1571833002
> https://codereview.chromium.org/1572703002
> 
> oshima@, did you have a reason to have both?  It seems safe to remove
> GetDeviceScaleFactorForTest now that we have GetDeviceScaleFactor.

I was working on multiple changes at the same time, and
I probably changed the test CL at some point because I somehow forgot about the
other CL.
The very first patch is actually using GetDeviceScaleFactor().

Thank you for catching this.


> LGTM, anyway.
> 
>
https://codereview.chromium.org/2123833002/diff/1/content/shell/renderer/layo...
> File content/shell/renderer/layout_test/blink_test_runner.cc (right):
> 
>
https://codereview.chromium.org/2123833002/diff/1/content/shell/renderer/layo...
> content/shell/renderer/layout_test/blink_test_runner.cc:712: float
> BlinkTestRunner::GetDeviceScaleFactorForTest() const {
> We could probably drop the "ForTest" from here as well.

[wjmaclean, 2016-07-06 18:19:46]

Description was changed from

==========
Remove duplicated function in RenderView.

BUG=none
==========

to

==========
Remove duplicated function in RenderView.

TBR=brettw@chromium.org
BUG=none
==========

[wjmaclean, 2016-07-06 18:20:08]

wjmaclean@chromium.org changed reviewers:
+ brettw@chromium.org

[wjmaclean, 2016-07-06 18:20:22]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-06 18:20:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 21:23:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 21:23:43]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[wjmaclean, 2016-07-06 21:36:06]

The CQ bit was checked by wjmaclean@chromium.org

[wjmaclean, 2016-07-06 21:36:06]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org
Link to the patchset: https://codereview.chromium.org/2123833002/#ps20001
(title: "Remove more 'ForTest' suffixes.")

[commit-bot: I haz the power, 2016-07-06 21:36:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 00:36:03]

Description was changed from

==========
Remove duplicated function in RenderView.

TBR=brettw@chromium.org
BUG=none
==========

to

==========
Remove duplicated function in RenderView.

TBR=brettw@chromium.org
BUG=none
==========

[commit-bot: I haz the power, 2016-07-07 00:36:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-07 00:36:17]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-07 00:37:34]

Description was changed from

==========
Remove duplicated function in RenderView.

TBR=brettw@chromium.org
BUG=none
==========

to

==========
Remove duplicated function in RenderView.

TBR=brettw@chromium.org
BUG=none

Committed: https://crrev.com/4fbd3d7485a9f6730be16a5e76c769a2b83961ac
Cr-Commit-Position: refs/heads/master@{#404016}
==========

[commit-bot: I haz the power, 2016-07-07 00:37:35]

Patchset 2 (id:??) landed as
https://crrev.com/4fbd3d7485a9f6730be16a5e76c769a2b83961ac
Cr-Commit-Position: refs/heads/master@{#404016}